Hi!
Thanks for doing this. There were several people asking about
Python wrappers for the PCP APIs at LCA in January, so it is
great to see this effort.
I can't offer much on the Python coding side of things, but this
patch fixes up some doco typos.
>From the comment at the top of pmapi.c, I wouldn't worry about
these few macros either:
PM_ERR_V1, XLATE_ERR_1TO2, XLATE_ERR_2TO1
The extended time base macros listed (PM_XTB_FLAG, PM_XTB_SET,
and PM_XTB_GET) will also likely never be needed by any modern
clients; pmTimeStateMode() in libpcp_gui is a better interface
to the PM_XTB_SET macro, which is the only one clients really
use.
Probably those macros should all really be in impl.h nowadays,
they shouldn't be used directly. Oh well, too late now I guess.
cheers.
--
Nathan
patch
Description: Binary data
|