pcp
[Top] [All Lists]

Re: [pcp] zbxpcp: add derived metrics support

To: Marko Myllynen <myllynen@xxxxxxxxxx>
Subject: Re: [pcp] zbxpcp: add derived metrics support
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri, 19 Feb 2016 03:52:25 -0500 (EST)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <56C6D039.7040808@xxxxxxxxxx>
References: <56BAF517.4030300@xxxxxxxxxx> <561951755.20107378.1455148828758.JavaMail.zimbra@xxxxxxxxxx> <56C35FEA.7080703@xxxxxxxxxx> <1756331291.21417357.1455663060401.JavaMail.zimbra@xxxxxxxxxx> <56C6D039.7040808@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: a44kNWxTdM8+hKlEztyEg0vfVAygFA==
Thread-topic: zbxpcp: add derived metrics support

----- Original Message -----
> On 2016-02-17 00:51, Nathan Scott wrote:
> > ----- Original Message -----
> >> [...]
> > Such a simple change, maybe its borderline - but it might be good to have
> > a regression check that if the file name (monster) is in place, and has a
> > valid (or invalid) content, then good stuff (or appropriate error) happens.
> > Up to you, its simple stuff - lemme know if you think its worth it; if not
> > I think we can just push in that pmLoadDerivedConfig patch as-is.
> 
> What do you think about this? $sudo must be defined in order this to work.

Looks good to me - I made some very minor tweaks for the overlapping changes
to handle pre-existing dynamic.indom.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>