pcp
[Top] [All Lists]

Re: [pcp] Solaris build notes

To: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Subject: Re: [pcp] Solaris build notes
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 25 Jun 2015 18:48:26 -0400 (EDT)
Cc: pcp <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <20150625161654.GF101450@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <474160992.25596336.1435198655884.JavaMail.zimbra@xxxxxxxxxx> <1945955780.25644422.1435200191659.JavaMail.zimbra@xxxxxxxxxx> <20150625133756.GB101450@xxxxxxxxxxxxxxxxxxxxxxxxx> <20150625161654.GF101450@xxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: xSuzl5q2quU1Mlf+hg7GQzkYkizH7w==
Thread-topic: Solaris build notes
Hi Jeff,

----- Original Message -----
> [...]
> Right, it finished.  I had to tweak the build trivially to get a 32-bit
> build.
> Without this trivial tweak (which you probably should *not* include),

*nod* - I think a variant of that patch would be fine though...

> linker error because qmake would try to shove in 64-bit Qt into an otherwise
> 32-bit build.  Note that OI Hipster uses gcc for everything unlike Solaris.
> 
> diff --git a/src/include/builddefs.in b/src/include/builddefs.in
> index d3408bf..4db796a 100644
> --- a/src/include/builddefs.in
> +++ b/src/include/builddefs.in
> @@ -163,7 +163,7 @@ GIT       = @GIT@
>  PYTHON       = @PYTHON@
>  PYTHON3      = @PYTHON3@
>  DTRACE  = @DTRACE@
> -QMAKE        = @qmake@
> +QMAKE        = @qmake@ -spec solaris-g++
> 

The configure.ac has knowledge of whether the platform is solaris (or alike),
as well as whether gcc or non-gcc compiler is being used (via $cc_is_gcc); so
a patch that expands @qmake@ in this situation to include that -spec option,
would certainly be a useful addition (iow, a configure.ac patch, rather than
a builddefs.in patch).

Did you need any other build changes?  Also, would you be able to add an
Illumos buildbot into Lukas' set?

  http://buildbot.pcp.io/ 
  http://pcp.io/buildbot.html

... would help us keep it up to date & automatically produce & test packages.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>