Hi Nathan
> Nice work - it's great to see all the docs and QA work done too - thanks!
>
> I noticed a few typos & unused imports in the python script, so fixed those
> up.
> We also sometimes add a "qa/archives/mk.xxx.sh" script when adding new test
> archives - I've added one because we'll need it shortly...
>
> There's a small problem in the script - it's using the original ipc.* names
> before
> I tweaked 'em for consistency. I've fixed this up in the script but we should
> re-create qa/archives/pcp-ipcs to match. Could you do that? (I would, but
> my system is not setup with an interesting sem/msg/shm like yours seems to
> be already - mostly zero values for me).
I have re-created qa archives. Please refer to the attachment.
> Also, the script accesses sysconf(SC_PAGE_SIZE) for reporting #pages. That
> should be using the "hinv.pagesize" metric instead (and perhaps use sysconf
> value as a fall-back?), so that the report is generated for the monitored
> system
> (which is possibly remote via --host) or archive. In both cases the values
> may
> not have come from a system with a pagesize matching the system where
> pcp-ipcs is being run.
Thank you for explanation.
Cheers
wuliming
Fix-the-method-of-getting-pagesize.patch
Description: Fix-the-method-of-getting-pagesize.patch
Fix-typo-using-latest-metric-names-and-recreate-pcp-.patch
Description: Fix-typo-using-latest-metric-names-and-recreate-pcp-.patch
pcp-ipcs.0
Description: pcp-ipcs.0
pcp-ipcs.index
Description: pcp-ipcs.index
pcp-ipcs.meta
Description: pcp-ipcs.meta
|