pcp
[Top] [All Lists]

Re: [pcp] [PATCH] build: fix configure path tests

To: David Disseldorp <ddiss@xxxxxxx>
Subject: Re: [pcp] [PATCH] build: fix configure path tests
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 6 Jun 2012 16:04:50 +1000 (EST)
Cc: pcp <pcp@xxxxxxxxxxx>
In-reply-to: <20120605153807.20dc300d@xxxxxxxxxxxx>
Hi Dave,


Hi,

Currently the test -z "`echo $pcp_share_dir | sed 's;/.*\$;;'`" based
configure tests always evaluate to true, the following proposed patch
attempts to fix this behaviour.

*nod*, looks odd indeed and fixing it makes sense.  I wasn't sure about the "\s" in
the sed regex and whether that would be supported on all platforms ... but, tried it
on freebsd (non-gnu sed) as well, and it seems to do the right thing.  The sed man
page there reckons basic REs are default, so should be fine.  I'll pull it in and let's
see how it goes - thanks!

cheers.

--
Nathan
<Prev in Thread] Current Thread [Next in Thread>