Re: [pcp] PCP Updates: Active Probing for __pmDiscoverServices() / pmfind

[Nathan Scott <nathans@xxxxxxxxxx>]

----- Original Message -----
> On 05/19/2014 04:16 AM, Nathan Scott wrote:
> > [...]
> > (this allocation ultimately seems to lead to one or two potential
> > memory leaks down the track ... but perhaps I'm missing something
> > subtle there)
> No memory leak here -- as discussed in earlier comments.
> 
> Thanks for the review! Let me know what you think about the items I've
> left open.
> 

Those explanations all seem fine to me - thanks for following up &
lemme know once all tested and ready to merge - I guess the sooner
the better, to dodge any more git-merge conflicts. :)

If you can think of a way to test that subtle memory alloc/freeing
is correct (perhaps a _run_valgrind test on pmfind?) that would be
super-mega-awesome.

cheers.

--
Nathan