Changes committed to git://oss.sgi.com/pcp/pcp.git dev
qa/286 | 44 +++++++++++++++++++++++++++++++++++++++++
qa/286.out | 1
qa/group | 1
src/pmdas/linux/linux_table.c | 15 ++++++++-----
src/pmdas/linux/numa_meminfo.c | 18 +++++++++-------
src/pmdas/linux/numa_meminfo.h | 3 +-
src/pmdas/linux/pmda.c | 7 +++---
src/pmdas/linux/proc_stat.c | 16 +++++++-------
8 files changed, 79 insertions(+), 26 deletions(-)
commit f95eba64016114a4d21e8610f158e4d900bc2889
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Sep 19 16:16:01 2012 +1000
Resolve pmdalinux ordering issue in NUMA/CPU indom setup
Another case of these two instance domains fighting for
setup priority. In the case of pmval fetching one of the
NUMA metrics before pmdalinux has to setup the proc_stat
and proc_cpustat, we can sneak in and only partially set
things up for proc_numastat. Ultimately, leads to a NULL
pointer dereference and sigsegv.
While in there, added a couple of missing guards around
very infrequent (initialisation-time) allocation calls.
Includes new QA test 286 which reproduces the originally
observed problem, by iterating over the kernel metrics
and doing some focused local context exercises.
Redhat BZ: 858384
Reviewed-by: Mark Goodwin <mgoodwin@xxxxxxxxxx>
|