pcp
[Top] [All Lists]

Re: [pcp] build woes (pmdajson related)

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, David Smith <dsmith@xxxxxxxxxx>
Subject: Re: [pcp] build woes (pmdajson related)
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 8 Jun 2015 19:54:27 -0400 (EDT)
Cc: PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <55720ED9.5030604@xxxxxxxxxxxxxxxx>
References: <55715217.7000009@xxxxxxxxxxxxxxxx> <55720ED9.5030604@xxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: ZN48jOsD2x7+BLbEGLg1/ds9ZnlEfg==
Thread-topic: build woes (pmdajson related)
Hi Ken,

Just catching up here... this my be resolved, but this bit:

----- Original Message -----
> On 05/06/15 17:39, Ken McDonell wrote:
> > ...
> The relevant package in Debian-land is python-json-pointer.
> 
> I've looked at the source some more, and now believe this is not really
> a build issue.  The jsonpointer and six modules are not needed in the
> build they are only needed at run-time.

(yep.)

> I suspect the rpm dependency is being added automagically by the rpm
> packaging (there is no reference to jsonpointer in the build/rpm
> directory),

... is not quite right - 

$ grep jsonpointer build/rpm/*
build/rpm/fedora.spec:Requires: python3-jsonpointer
build/rpm/fedora.spec:Requires: python-jsonpointer
build/rpm/pcp.spec.in:Requires: python3-jsonpointer
build/rpm/pcp.spec.in:Requires: python-jsonpointer

> so that leaves the old rpm platforms as a bit of an issue.
> 
> For the non-rpm platforms we can live without any packaging dependency
> (I think) provided we guard against inappropriate execution in the QA

Traditionally, the more diligent PMDA Install scripts have checked for
runtime prerequisite modules / commands (eg src/pmdas/postfix/Install,
src/pmdas/vmware/Install, etc), we should really add that verification
here as well for the non-rpm platforms.  I completely forgot about this
when reviewing, sorry - will add some checks shortly.


On that more general issue of having PCP continue to work on older distros
even if the distro vendors have moved on - I agree we should not use this
as a reason to not (continue to) have PCP work there.  In my experience
some sites will continue to run those older distros long after the vendors
stop caring, and in almost all cases its no big deal to make PCP (continue
to) work there via configure.ac guards, conditional build/compilation, etc.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>