pcp
[Top] [All Lists]

pcp updates: kenj+fche merges

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: pcp updates: kenj+fche merges
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun, 17 Nov 2013 22:40:04 -0500 (EST)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <42710475.6968472.1384745935771.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: v7CBoKjfAs0zLde+AznWXa531caoKA==
Thread-topic: pcp updates: kenj+fche merges
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 qa/359                          |    2 
 qa/370                          |    8 ++-
 src/libpcp/src/auxconnect.c     |    2 
 src/pmdas/linux_proc/proc_pid.c |  106 ++++++++++++++++++++++++++++------------
 4 files changed, 86 insertions(+), 32 deletions(-)

commit 6f2777e0392127773e67b2002832e3af4c513827
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Nov 18 14:37:38 2013 +1100

    Do not initialise a hostent name with a bogus non-heap name
    
    If we cannot resolve a hostname in __pmHostEntGetName, it is
    not useful to initialize it to "Unknown Host".  No good will
    ever come from faking a host name in this way, and libpcp is
    now demonstrably exposed to __pmHostEntFree failure when its
    time to free the hostent structure.

commit ac82c63b9c48f24e3c80c2bf20534938efecf72f
Merge: e3293ef 6e5b567
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Nov 18 14:25:50 2013 +1100

    Merge branch 'fche/dev' of ../pcpfans into dev

commit e3293ef7176aadfe8d89e7e26e41f0d80cc17fb8
Merge: 7fc6219 32f7bc6
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Nov 18 14:03:27 2013 +1100

    Merge branch 'dev' of git://oss.sgi.com/kenj/pcp into dev

commit 32f7bc63b943e984cbb9817072b232e117aeb515
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Nov 12 10:53:08 2013 +1100

    proc pmda - dodge wchan sometimes not available
    
    Recent thread semantics changes to the proc pmda have been resulting in
    qa/022 failing on some platforms.
    
    This was eventually tracked down to /proc/PID/task/PID/wchan being
    sometimes (unexpectedly) empty, and causing the other proc metrics to
    be unavailable.
    
    Fix this, and retain all the verbose diagnostics used to find this (all
    under -D libpmda AND -D desperate control).

commit 5bd200ba4db811e8e8bfcbffc9d63012c64e4b27
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Nov 8 18:30:46 2013 +1100

    qa/359 - filtering change
    
    email summarizes all that matters ...
    
    Ken asks ...
    > Can anyone explain a recent change that produces this
    >
    > $ pminfo -v proc.psinfo
    > proc.psinfo.cgroups: Unknown or illegal instance identifier
    > proc.psinfo.labels: Unknown or illegal instance identifier
    >
    > on some systems and not others?
    
    And Nathan replies ...
    >> This is exporting /proc/PID/cgroup and /proc/PID/attr/current
    >> values.  It looks like systems where these files are empty or
    >> otherwise return an error on open, will cause the above inst
    >> error.  I guess thats because all the proc.psinfo metrics use
    >> the same ("all processes") indom.
    >>
    >> It can be safely filtered, thanks.

commit e18b37d50dfd50217b1479e8ffc0bef3df0721b7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Nov 8 09:01:14 2013 +1100

    qa/370 - fix regression
    
    Need proc.nprocs -> proc.nproc mapping in the pmdumplog filter after
    sar2pcp changes in commit 48e373f0609a0a0804bc052d5e9dec41a5a2928e
    so output matches the boatload of 370's "out" files.
    
    Should be proc.nprocs so the sar2pcp commit is correct, but all the
    old systems will match the old "out" files, so simplest to reverse
    the effects of the commit in the output filter.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: kenj+fche merges, Nathan Scott <=