Re: [pcp] pmrep: tweak unit string

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Marko,

----- Original Message -----
> [...]
> 
> Ok, let's switch to the compact form, the change is trivial and it
> covers all the existing metrics (in fact the millisec case is only
> needed for a metric from the sample PMDA). Change to this direction
> doesn't require QA updates.
> 
> ---
>  src/pmrep/pmrep.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/pmrep/pmrep.py b/src/pmrep/pmrep.py
> index b330ca6..d73dda2 100755
> --- a/src/pmrep/pmrep.py
> +++ b/src/pmrep/pmrep.py
> @@ -739,7 +739,8 @@ class PMReporter(object):
>                              label = "util"
>                      self.metrics[metric][2] = (label, unitstr, mult)
>                  else:
> -                    self.metrics[metric][2] = (unitstr, unitstr, 1)
> +                    label = unitstr.replace(" / sec", "/s").replace(" / 
> millisec", "/ms")

Hmm, there's several other possible strings there - src/libpcp/src/units.c
has the full list - need to deal with those too?  (microsec, nanosec, etc)

cheers.

--
Nathan