pcp
[Top] [All Lists]

Re: [pcp] qa/1111 failing pretty much every place it is run

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] qa/1111 failing pretty much every place it is run
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed, 13 Jul 2016 19:56:03 +1000
Cc: Alec Ten Harmsel <alec@xxxxxxxxxxxxxxxxxx>, PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <2007799860.5569194.1468379983465.JavaMail.zimbra@xxxxxxxxxx>
References: <57858370.8030700@xxxxxxxxxxxxxxxx> <131083523.5554077.1468368582128.JavaMail.zimbra@xxxxxxxxxx> <57859524.6050605@xxxxxxxxxxxxxxxx> <984783794.5564620.1468374521886.JavaMail.zimbra@xxxxxxxxxx> <5785B148.1090200@xxxxxxxxxxxxxxxx> <2007799860.5569194.1468379983465.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0
On 13/07/16 13:19, Nathan Scott wrote:


----- Original Message -----
[...]
No deps for deb.  And check-vm was only checking for python(2) version,
but we've moved the deb build to using python3 when available and
python3-requests was not installed.  Fixed this and passes on one host
(so far).

Hmm - debian/control.master has

Package: pcp-export-pcp2influxdb
Depends: ${python:Depends}, [...], python3-requests | python-requests

which I'd have thought would pull it in for QA too?

Well we're probably just another victim of the simple minds of the Python pixies that apparently thought compatibility between versions was something that did not matter.

The prereq will be satisfied by python-requests when python3-requests is *not* installed, which won't help if configure has decided to use python3 ... this probably needs configure-driven magic to customize the debian/control file to make the Depends: line python3-requests if PCP is using python3 else python-requests if PCP is using python(2), rather than the alternation construct at the moment.

<Prev in Thread] Current Thread [Next in Thread>