pcp
[Top] [All Lists]

Re: perl-LDAP prerequisite for rpm packages

To: Marko Myllynen <myllynen@xxxxxxxxxx>
Subject: Re: perl-LDAP prerequisite for rpm packages
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed, 13 Jul 2016 06:25:46 +1000
Cc: PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0
Marko,

I'm afraid you cannot simply do this ...

commit 7a975d2b739aff75c9b2241c3b80cfb3613b6a78
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date:   Mon Jul 11 08:37:23 2016 +1000

    build: add to ds389{,log} RPM package dependencies

    Resolves RH BZ# 1354055

because perl-LDAP is not available as an rpm package for all platforms where we build PCP rpms, and in these cases we have the option of installing Net::LDAP via cpan so the PMDA works even when the rpm prereq is not satisified.

So this change breaks the installs on those platforms (I have 2 of 'em so far in my QA Farm).

I believe the correct way to address this sort of issue is either:

(a) add configure glue to detect if the PMDA should be built and packaged, then use a
%if "@enable_mypmda@" == "true"
guard in the rpm spec file, or

(b) if the Requires/BuildRequires prereq is needed but only safe on some distros, then use something like
%if 0%{?rhel} > 5
as a guard in the rpm spec file

Of course (a) is preferred.

The perl-Date-Manip one seems safer as that would appear to be more widely available.

I've reverted the perl-LDAP one in my tree.

<Prev in Thread] Current Thread [Next in Thread>