pcp
[Top] [All Lists]

pmrep: add support for containers

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: pmrep: add support for containers
From: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Mon, 20 Jun 2016 14:43:28 +0300
Delivered-to: pcp@xxxxxxxxxxx
Organization: Red Hat
Reply-to: Marko Myllynen <myllynen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0
Add containers support for pmrep(1), nicely illustrates the
power of the underlying machinery.

---
 src/pmrep/TODO     | 1 -
 src/pmrep/pmrep.1  | 8 ++++++++
 src/pmrep/pmrep.py | 1 +
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/pmrep/TODO b/src/pmrep/TODO
index ea8878b..3d30f81 100644
--- a/src/pmrep/TODO
+++ b/src/pmrep/TODO
@@ -8,7 +8,6 @@
 -  support rate display also for non-cumulative counters
 -  support displaying raw/rate as per given unit
 -  (re)add runtime directive to config file
--  containers support (depends on RHBZ#1333702)
 -  add JSON output support
 -  add XML output support (like sadf)
 -  add XLS output support (like sar2xls)
diff --git a/src/pmrep/pmrep.1 b/src/pmrep/pmrep.1
index d8fa2d6..2e91f92 100644
--- a/src/pmrep/pmrep.1
+++ b/src/pmrep/pmrep.1
@@ -22,9 +22,11 @@
 \f3pmrep\f1
 [\f3\-CdGHLpruUVxz?\f1]
 [\f3\-a\f1 \f2archive\f1]
+[\f3\--archive-folio\f1 \f2folio\f1]
 [\f3\-A\f1 \f2align\f1]
 [\f3\-b\f1 \f2space-scale\f1]
 [\f3\-c\f1 \f2config\f1]
+[\f3\--container\f1 \f2container\f1]
 [\f3\-e\f1 \f2derived\f1]
 [\f3\-E\f1 \f2lines\f1]
 [\f3\-f\f1 \f2format\f1]
@@ -258,6 +260,12 @@ Unlike with other options,
 must be separated by a space from
 .BR \-c .
 .TP
+.B \-\-container
+Fetch performance metrics from the specified
+.IR container ,
+either local or remote (see
+.BR \-h ).
+.TP
 .B \-C
 Exit before reporting any values, but after parsing the configuration
 and metrics and printing possible headers.
diff --git a/src/pmrep/pmrep.py b/src/pmrep/pmrep.py
index 7555f3f..eb0d1dd 100755
--- a/src/pmrep/pmrep.py
+++ b/src/pmrep/pmrep.py
@@ -310,6 +310,7 @@ class PMReporter(object):
         opts.pmSetLongOptionHeader("General options")
         opts.pmSetLongOptionArchive()      # -a/--archive
         opts.pmSetLongOptionArchiveFolio() # --archive-folio
+        opts.pmSetLongOptionContainer()    # --container
         opts.pmSetLongOptionHost()         # -h/--host
         opts.pmSetLongOptionLocalPMDA()    # -L/--local-PMDA
         opts.pmSetLongOptionSpecLocal()    # -K/--spec-local

Thanks,

-- 
Marko Myllynen

<Prev in Thread] Current Thread [Next in Thread>
  • pmrep: add support for containers, Marko Myllynen <=