Nathan,
The control.local one was the real killer that lead to all my qa directory
being donated to the user pcp on vm04.
Of course if the pmie_check changes had been identified and made earlier, then
the damage would not have happened ... 8^)
Getting rid of the recursive chown is a good thing ... I'll go look at the
pmlogger_check case now and see if I can expunge it there as well.
Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (3):
src/pmie/control.local: add explicit $version
src/pmie/pmie_check.sh: extra hardening
qa/115: much better coverage of pmie_check test cases
qa/115 | 167 +++++++++++++++++++++++++++++++++++++++++++++++--
qa/115.out | 156 +++++++++++++++++++++++++++++++++++++++++++++
src/pmie/control.local | 2
src/pmie/pmie_check.sh | 83 ++++++++++++++++++++----
4 files changed, 390 insertions(+), 18 deletions(-)
Details ...
commit 66cf4d72f84d5f3f35b80c73adfb407d8f6fdc47
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jun 10 09:01:42 2016 +1000
qa/115: much better coverage of pmie_check test cases
commit ac64ca90b5fddf44a6a111090ac5ca9b74827771
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jun 10 08:57:55 2016 +1000
src/pmie/pmie_check.sh: extra hardening
Greatly improved the error checking of the control file in the
wake of the great qa/115 disaster.
Also expunged the chown -R that is dangerous in the extreme ...
I don't think this is necessary at all once the directory containing
the log file and the log file itself (if it exists) are accounted for
with explicit chown actions.
commit b3a3b11ba2fb1a21aaa0d5b14034727f2d1f5d03
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jun 10 08:39:50 2016 +1000
src/pmie/control.local: add explicit $version
This file is v1.1 format, but the missing $version line meant
it was interpreted as v1.0 format (former default) with one
less field expected ... all hell broke lose as a result.
|