Hey Nathan
Looking good - just a couple of thoughts.
It may be hard to use the bin/parfait.sh wrapper script for existing
packaged software. It would be good to show an example usage of calling
the agent with the java command. Some java software allows for a
JAVA_OPTS environment variable to be set or some override in
/etc/sysconfig/myservice. People could then extrapolate from the raw
command. EG
java
-javaagent:/usr/share/parfait-0.3.8.jar=name:foops,cluster:123,interval:1 -jar
myApp.jar
Also, to lower the barrier to entry even more, you could provide the
link to the java agent to download when it gets released on Maven so
people can compile if they want or just wget it straight away. Eg:
wget
https://repo1.maven.org/maven2/com/custardsource/parfait/parfait-core/0.3.7/parfait-agent-0.3.7.jar
On 28/04/16 17:48, Nathan Scott wrote:
Hi guys,
I've made a little write-up on setting up parfait-agent to instrument
a Java application, and added it to the main Parfait README. You can
read it online here:
https://github.com/natoscott/parfait
If you have some spare time to read and/or try it out, I'd love to hear
your thoughts - thanks!
Changes committed to git://git.pcp.io/nathans/parfait.git master
Nathan Scott (1):
docs: improve markup and general readability in README.md
README.md | 126
+++++++++++++++++++++++++++++++++++++-------------------------
1 file changed, 76 insertions(+), 50 deletions(-)
cheers.
--
Nathan
_______________________________________________
pcp mailing list
pcp@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/pcp
|