pcp
[Top] [All Lists]

Re: [pcp] pcp updates: log tools longopts, pmdacisco

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] pcp updates: log tools longopts, pmdacisco
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 24 Apr 2014 00:06:10 -0400 (EDT)
Cc: PCP Mailing List <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <751138293.10179218.1398312056455.JavaMail.zimbra@xxxxxxxxxx>
References: <751138293.10179218.1398312056455.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: sK/Som4BuLtsVjYP3GZqQuydKAB2AmZDp2og
Thread-topic: pcp updates: log tools longopts, pmdacisco
Hi Ken,

Could I get you to pass an especially critical eyeball over the
following commit please?  I think everything still works exactly
as before there (except qa/379 completes quickly for me now).  I
left the (newly added) debugging options undocumented on purpose
(like -D usually is).

thanks!

----- Original Message -----
> Changes committed to git://git.performancecopilot.org/pcp.git dev
> 
>  qa/379                          |    4
>  [...]
>  src/pmdas/cisco/.gitignore      |    2
>  src/pmdas/cisco/GNUmakefile     |   20 --
>  src/pmdas/cisco/parse.sh        |    3
>  src/pmdas/cisco/pmda.c          |   97 ++++++-----
>  src/pmdas/cisco/probe.c         |   15 +
>  [...]
> commit 8da53d2672b84c1221aa4d2aa8f54a8d648cf86d
> Author: Nathan Scott <nathans@xxxxxxxxxx>
> Date:   Thu Apr 24 11:10:29 2014 +1000
> 
>     Rework the parse mode in pmdacisco for QA testing efficiency
>     
>     Change the Cisco PMDA parse mode to tackle intermittent failure
>     in test qa/379.  Simply moving a diagnostic to before a thread
>     is started removed the main race.  But, digging into it, found
>     the test running significantly longer than it should due to many
>     (unresolvable) DNS lookups - so, allow those to be disabled too
>     for QA, making it run alot quicker (1 minute -> 1 second).
>     
>     Instead of building pmdacisco twice (second time for parse), we
>     now use a shell script front for pmdacisco and a single binary.

<Prev in Thread] Current Thread [Next in Thread>