pcp
[Top] [All Lists]

pcp updates - mostly qa, a couple of small code changes

To: pcp@xxxxxxxxxxx
Subject: pcp updates - mostly qa, a couple of small code changes
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue, 15 Mar 2016 20:33:59 +1100
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
[Dave ... your call if these are in or out for the next release]

Changes committed to git://git.pcp.io/kenj/pcp master

Ken McDonell (10):
      qa/738: handle more bizarre error message formats from rm(1) and ln(1)
      src/pmlogger/pmlogmv.sh: fix bug for non-Linux systems
      qa assorted: more sudo problems, this time for dbpmda
      qa/common.check: rework _check_freespace() because of df(1) differences
      qa/944: filter out additional error message text from Mac OS X
      qa/919: rm 919.out ... missed in last round of changes for qa/919
      darwin PMDA: add mem.util.used metric
      qa/786: Linux and BSD cannot agree on value for EHOSTUNREACH
      logger PMDA: report error if regcomp() fails
      pmevent: clarify -x option

 man/man1/pmval.1         |   11 +++++++++--
 qa/137                   |    6 +++---
 qa/147                   |    2 +-
 qa/397                   |    2 +-
 qa/416                   |    2 +-
 qa/461                   |    2 +-
 qa/553                   |   12 ++++++------
 qa/617                   |    2 +-
 qa/716                   |    2 +-
 qa/718                   |    2 +-
 qa/721                   |    4 ++--
 qa/738                   |   18 ++++++++++++++----
 qa/738.out               |   12 ++++++------
 qa/784                   |    4 ++--
 qa/786                   |    8 +++++++-
 qa/789                   |    2 +-
 qa/798                   |    2 +-
 qa/800                   |    8 ++++----
 qa/813                   |    2 +-
 qa/919.out               |    7 -------
 qa/944                   |    4 +++-
 qa/955                   |    8 ++++----
 qa/967                   |    8 ++++----
 qa/976                   |    2 +-
 qa/981                   |    2 +-
 qa/common.check          |   16 ++++++++++++++--
 src/pmdas/darwin/help    |    2 ++
 src/pmdas/darwin/pmda.c  |    7 +++++++
 src/pmdas/darwin/pmns    |    1 +
 src/pmdas/logger/event.c |    4 +++-
 src/pmlogger/pmlogmv.sh  |   21 ++++++++++++++++++++-
 31 files changed, 123 insertions(+), 62 deletions(-)

Details ...

commit 353fc25b4755db3da36c5504bec45d4479ebcbde
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 19:52:12 2016 +1100

    pmevent: clarify -x option
    
    1. make reference to argument consistent in the man page
    2. document that argument should not be an empty string, and
       "." is the best chance for a match-all pattern
    3. change qa/461 to use -x '.' rather than -x ''
    
    And yes, of course this all blew up on Mac OS X where regcomp()
    is different and treats an empty RE as an error.

commit 86dd82fa38802480100c671e9fd78517fa56c8f4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 18:29:12 2016 +1100

    logger PMDA: report error if regcomp() fails

commit a31514399dd7ddf0241249442cf0c1189be7237b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 16:00:57 2016 +1100

    qa/786: Linux and BSD cannot agree on value for EHOSTUNREACH

commit 9932b029e6a63b4730b5afe4f135595d9847f3d4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 15:51:40 2016 +1100

    darwin PMDA: add mem.util.used metric

commit 6fe5f69d3ad19b48ee72c09c6faa8eb25bd2a213
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 15:38:36 2016 +1100

    qa/919: rm 919.out ... missed in last round of changes for qa/919

commit d3a04aace22ce189330cda1a2de9e8c33f0eb216
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 15:38:05 2016 +1100

    qa/944: filter out additional error message text from Mac OS X

commit 13d29cd438e0dab03f53493d8b9ea22a99f7f540
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 15:33:56 2016 +1100

    qa/common.check: rework _check_freespace() because of df(1) differences
    
    The Linux-based and BSD-based implementations of df(1) have mutually
    conflicting and inconsistent command line options ... special case
    this in _check_freespace().

commit dffaec64595e3d454848e3094ab9d481d2373d76
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 15:28:49 2016 +1100

    qa assorted: more sudo problems, this time for dbpmda
    
    The cause is sudo(1) clearing $TERM from the environment ... not much
    of an issue, you say, but "$sudo dbpmda" prattles on for Mac OS X
    because dbpmda uses readline which depends on terminfo which babbles
    when TERM=unknown.
    
    Replace dbpmda invocations like this with "$sudo TERM=ansi dbpmda ..."
    or something similar.

commit 2b657395d44c3b84160222dc8b1e012161431e32
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 12:22:53 2016 +1100

    src/pmlogger/pmlogmv.sh: fix bug for non-Linux systems
    
    Script contained a fragment to extract the link count for a file
    from the output of stat(1) ... this did not work at all for the
    BSD-based systems where stat(1) is completely different.

commit 362bb82922317bcdd8e34de500416d1682b9dfa7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 15 12:22:10 2016 +1100

    qa/738: handle more bizarre error message formats from rm(1) and ln(1)

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates - mostly qa, a couple of small code changes, Ken McDonell <=