Here's the promised QA updates for the global derived metrics feature.
Dave, don't pull this unless you also pull the global-derived-metrics
changes listed below, thanks.
Changes committed to git://git.pcp.io/mgoodwin/pcp master
commit f68c60427318969196efc006428d8055417c442c
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Mar 15 12:23:00 2016 +1100
qa: updates to 'derive' group tests for global derived metrics
updates qa/225 qa/246 qa/247 qa/249 qa/256 qa/370 qa/509 qa/969
but no new qualified output.
On 03/15/2016 10:23 AM, Mark Goodwin wrote:
After discussion on the list, also support PCP_DERIVED_CONFIG defined to
a zero length string to disable loading any derived metrics configs. This
feature now only needs some QA and doc updates, which I'll do today.
Dave - up to you whether to take this for 3.11.1. It's been in my tree for
about a week (except for todays small change) and it's all client-side,
but we're now in QA-week, so your call - BTW the iostat derived metrics and
new pmchart views are super useful for storage analysis.
Changes committed to git://git.pcp.io/mgoodwin/pcp master
commit d00d400dd591adba8403b97d2705c3bda052ee72
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Mar 15 09:53:51 2016 +1100
libpcp: PCP_DERIVED_CONFIG=="" disables loading derived metrics
Also add a comment explaining the three use-cases:
If PCP_DERIVED_CONFIG is NOT set, then by default we load global
derived configs from the directory $PCP_VAR_DIR/config/derived.
If PCP_DERIVED_CONFIG is set to a zero length string, then don't
load any derived metrics definitions.
Else if PCP_DERIVED_CONFIG is set then load user-defined derived
metrics from one or more files or directories separated by ':'.
On 03/09/2016 11:01 PM, Mark Goodwin wrote:
This adds a new config directory for global derived metrics definitions,
loaded by libpcp __dminit() if $PCP_DERIVED_CONFIG is NOT set in the
environment.
Adds iostat.conf derived metrics and a new Iostat view for pmchart. Since this
is
all client side, the new derived metrics and pmchart view work on current pmcd
and
existing archives. Generic tools can now report Iostat metrics, and any other
derived metrics that are added to the global config directory. e.g. if you only
have
one disk, the following is almost the same as iostat:
pmrep disk.dev.{read_bytes,write_bytes,await,avg_rqsz,avg_qlen,util}
Still to come: QA - please don't consider merging this until I've finished
the necessary QA updates and added a few new tests.
Changes committed to git://git.pcp.io/mgoodwin/pcp master
commit b83ef983a98979528a3d70736c0dc3c6677075ce
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 22:05:16 2016 +1100
packaging: packaging for global derived metrics configs
Add new dir PCP_VAR_DIR/config/derived and config file iostat.config
to the pcp-config package.
modified: build/rpm/fedora.spec
modified: debian/pcp-conf.dirs
modified: debian/pcp-conf.install
commit 7a4d099ce75c035c701e153bd3bfedbdcd61f3e0
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 21:57:32 2016 +1100
pmchart: add Iostat view using disk metrics and derived iostat metrics
This is a new multi-tabbed view showing disk and device-mapper traffic
and most of the traditional iostat metrics. Some of these metrics are
derived, see /var/lib/pcp/config/derived/iostat.conf.
modified: src/pmchart/views/GNUmakefile
new file: src/pmchart/views/Iostat
commit 5d5620645415100a4734d379f111b179c25267d6
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 17:41:05 2016 +1100
libpcp: load global derived metrics config by default
If PCP_DERIVED_CONFIG is NOT defined in the environment, then __dminit()
now loads derived configs from $PCP_VAR_DIR/config/derived by default.
This follows on from previous commit 689c031ca6f5, where we now ship
an iostat.config.
A follow-up change will move the global derived config directory and
iostat.config into the pcp-conf package (currently in pcp base package).
Also, some QA changes to follow.
commit 0b91a221b8187f11d7c1dd05a222ab3f94f63d35
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 17:26:33 2016 +1100
pmchart: fix an autoscale bug when loading a view in archive mode
Fix an issue in pmchart when loading a view in archive mode, autoscale
isn't properly performed until a pmtime event is received (was initially
fixed scale at 0 .. 1000). Also improves console diagnostics in related
areas of code. Fix is in GroupControl::adjustArchiveWorldViewForward().
commit df5ec5921a8dab639530d939fb43382d18921305
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 17:17:46 2016 +1100
docs: clarify pmchart -geometry and -g flags (former is for display
geometry)
commit 5c6ed952f33490aedd0a0ebb898e32001cc0146e
Merge: 7a2d529 689c031
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 17:15:43 2016 +1100
Merge branch 'master' of git://pcp.io/mgoodwin/pcp
commit 689c031ca6f5db455cce6aab8f145eb5b8029223
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Mar 7 15:23:56 2016 +1100
config: install a global derived metrics config directory with iostat.conf
Installs a global derived metrics config dir $PCP_VAR_DIR/config/derived
along with iostat.conf (containing iostat derived metrics definitions).
modified: src/GNUmakefile
new file: src/derived/GNUmakefile
new file: src/derived/iostat.conf
|