Hi Ken,
On 2016-02-22 05:25, Ken McDonell wrote:
> On 23/11/15 20:50, Marko Myllynen wrote:
>
> Sorry Marko, it has taken a few months to get to this ...
Certainly better late than never :-)
>> I see -O described in PCPIntro(1) as expected but pmprobe(1) and
>> pminfo(1) also discuss an -O related timezone issue which is not
>> described in PCPIntro(1), pmval(1), or pmdumptext(1). If the issue is a
>> general one, could the discussion perhaps moved to PCPIntro(1)? (While
>> at it, perhaps it could also be clarified a bit, I had to read it twice
>> to get a hang of it.)
>
> I've culled the text from pmprobe(1) and pminfo(1) and revamped the text
> and inserted it into PCPIntro(1).
Looks good.
>> Also, in few clients I see this kind of code used in preparation for a
>> pmSetMode(1) call:
>> ...
>> I don't think merely by reading the current pmSetMode(1) a client
>> developer could instantly see something like this would be needed. As
>> per the best cargo-cult practices I already started to use something
>> similar in pmrep but might still be nice to have few words about this in
>> pmSetMode(1)?
>
> Fair point ... 1. this code is ugly and 2. the pmSetMode(1) verbage
> gives no clue how to use PM_XTB_SET().
>
> I've reworked pmSetMode(1) to try and explain better and give a less
> convoluted example.
And now the magical 24 day mark is explained nicely.
> Lemme know if these changes help once my commits percolate back to the
> main tree.
It's all clear now, thanks a lot.
Cheers,
--
Marko Myllynen
|