pcp
[Top] [All Lists]

pmrep: don't do fsync

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: pmrep: don't do fsync
From: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Wed, 17 Feb 2016 08:56:37 +0200
Delivered-to: pcp@xxxxxxxxxxx
Organization: Red Hat
Reply-to: Marko Myllynen <myllynen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
We agreed with Frank on IRC that this is overkill,
we'll just let the OS/kernel do its job.

---
 src/pmrep/pmrep.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/pmrep/pmrep.py b/src/pmrep/pmrep.py
index fd3d0ee..73c4a61 100755
--- a/src/pmrep/pmrep.py
+++ b/src/pmrep/pmrep.py
@@ -1350,8 +1350,6 @@ class PMReporter(object):
                 self.writer.flush()
             except BrokenPipeError:
                 pass
-            if self.writer != sys.stdout:
-                os.fsync(self.writer.fileno())
             self.writer.close()
             self.writer = None
         if self.pmi:

Thanks,

-- 
Marko Myllynen

<Prev in Thread] Current Thread [Next in Thread>
  • pmrep: don't do fsync, Marko Myllynen <=