Hi,
On 2016-02-17 00:42, Nathan Scott wrote:
> ----- Original Message -----
>> [...]
>>>
>>> This seems to be a common and known issue on such old python versions -
>>> is it worth doing something about it?
>
> (yes, definitely)
>
>> It depends - RHEL 6's Python 2.6 gained OrderedDict in RHEL 6.5:
>
> PCP runs on many other platforms though, and it would be best to have pmrep
> available on all supported platforms (incl. EPEL5, but also many other non-
> Red Hat Linux distros, not to mention Mac OS X, *BSD and so on).
Supporting different distributions is entirely different thing than
supporting unsupported OS releases.
>> So if we're adjusting things for RHEL 6 I think perhaps we could
>> check whether OrderedDict is available but disabling pmrep altogether
>> sounds a step too far IMHO.
>
> Can we rearrange the code to not use an OrderedDict? (e.g switch to a
> regular dict, and arrange to have metrics sorted before displaying? -
> there is lots of other (needed?) use of OrderedDict's though so I'm not
> sure its that simple.
I'd rather put the effort into taking pmfg into use, that should also
increase overall readability and performance. I'll probably look into
that once the QA tests are a bit more complete.
Thanks,
--
Marko Myllynen
|