Re: [pcp] pmrep: fix timezone handling/reporting

[Marko Myllynen <myllynen@xxxxxxxxxx>]

Hi,

On 2016-02-08 23:50, Nathan Scott wrote:
> ----- Original Message -----
>> [...]
>>> As discussed in that other thread, we've managed to avoid some helper
>>> routines in pmrep (pmGetContextOptions in particular) which might've
>>> made some of this easier, not sure (if we are really out of sync, we
>>> will not be helped by that I guess).
>>
>> One reason why we've avoided using pmGetContextOptions in pmrep is that
>> it's not available via the Python PMAPI :-)
> 
> Its there, its just not directly called - pmContext.fromOptions builder
> interface makes use of it (hmm, which pmrep already uses?) via:
> 
>         # finish time windows, timezones, archive access mode
>         if c_api.pmSetContextOptions(context.ctx, options.mode, 
> options.delta):
>             raise pmUsageErr
> 
> (which internally calls pmGetContextOptions)

Ah ok, I didn't see pmGetContextOptions in pmapi.py thus thought it's
not available. But yes, pmrep already uses pmContext.fromOptions:

    def connect(self):
        """ Establish a PMAPI context to archive, host or local, via
args """
        self.context = pmapi.pmContext.fromOptions(self.opts, sys.argv)


Thanks,

-- 
Marko Myllynen