pcp
[Top] [All Lists]

pcp updates

To: pcp@xxxxxxxxxxx
Subject: pcp updates
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri, 22 Jan 2016 11:40:37 +1100
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
Changes committed to git://git.pcp.io/kenj/pcp master

Ken McDonell (2):
      libpcp: add missing pthread_mutex_destroy calls for pc_lock (pmcd ipc 
lock)
      qa/662: increase polltimeout from 2 to 5

Dave Brolley (1):
      Fix bug in interp mode record caching.

 qa/662                                 |    4 
 qa/src/test_webapi.python              |    7 
 src/libpcp/src/context.c               |   60 
 src/libpcp/src/interp.c                |   40 

Details ...

commit edd88b9158112104688fbb9e2ea72f331051d6fb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Jan 22 08:39:04 2016 +1100

    qa/662: increase polltimeout from 2 to 5
    
    Was failing on some slow VMs with contexts being timeout early in the
    middle of the test.

commit 1533df8944723fa8895d4036e6fef5cc7ae23099
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Thu Jan 21 16:27:16 2016 -0500

    Fix bug in interp mode record caching.
    
    Records were cached based on
      1) metrics file pointer(!!!!)
      2) volume number
      3) offset in the metrics file
    
    The problem with this is that it is possible for the metrics file
    pointer to remain the same when a volume/archive change occurs. In this
    case%2C if the previous volume is small enough%2C records from the new
    volume may be determined to be cache hits for records in the cache
    from the old volume.
    
    This change uses the name of the archive instead of the metrics file
    pointer%2C as is done elsewhere in libpcp when distinguishing archives.

commit f995cc7f629845621729f4ff83310669dd1ba316
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Jan 22 06:59:20 2016 +1100

    libpcp: add missing pthread_mutex_destroy calls for pc_lock (pmcd ipc lock)
    
    Original patch by Markiyan Kushnir <markiyan.kushnir@xxxxxxxxx>
    to address https://github.com/performancecopilot/pcp/issues/62.
    
    Some refactroring to "downgrade" the name of the new static function
    involved (and on reflection some of their peers in context.c) from
    __pmFooBar() to foobar() as these symbols are not%2C and never will be%2C
    visible at the library API (cosmetic and code readability issue).


<Prev in Thread] Current Thread [Next in Thread>