On 01/08/2016 11:32 PM, Marko Myllynen wrote:
Hi,
On 2016-01-02 07:25, Frank Ch. Eigler wrote:
As requested, I added a fetchgroup-flavoured PM_TYPE_EVENT processor
to the work. pcpfans.git fche/fetchgroup. The new commit is:
fetchgroups: event-field support
Extend the fetchgroup api with an _event variant, which processes
named fields from named event metrics through the extract/convert/cast
pipeline.
Python & docs & QA included.
Thanks a lot, this is very nice indeed.
Should we start planning merging pmfg now?
yes we should. IMO it's in good shape for merge and have discussed this with
Nathan.
I'm planning to merge it to master as soon as I've finished the last few review
tasks
(the events support in particular) - probably sometime tomorrow. I'm still not
terribly
happy with the use of 'ambiguous sentinels' in lieu of the optional error array
parameters but as Frank mentioned, programmers always have the option of using
the
error arrays as best-practice.
Regards
-- Mark
|