pcp
[Top] [All Lists]

Adjust zbxpcp installation directory

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: Adjust zbxpcp installation directory
From: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Mon, 30 Nov 2015 12:57:44 +0200
Delivered-to: pcp@xxxxxxxxxxx
Organization: Red Hat
Reply-to: myllynen@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
Hi Nathan,

pardon me for not reviewing the zbxpcp build bits earlier but I think we
should make a few changes there. I also wrote a zbxpcp(3) man page which
we can add while at it.

The patch below changes to the zbxpcp installation target. The below
find stanza shows that typically such modules are installed under
/usr/lib(64)/<package>/modules. Since we're dealing with a Zabbix agent
module and the example in the Zabbix loadable modules page use
/usr/local/lib/zabbix/agent/ I'm proposing the directory below.

This also fixes "make install" failure occurring currently.

This might require spec changes but see the following patches as well.

$ sudo find /usr /var -type d -name modules -print

---
 src/pcp2zabbix/src/GNUmakefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pcp2zabbix/src/GNUmakefile b/src/pcp2zabbix/src/GNUmakefile
index 6d5f2b3..cc15204 100644
--- a/src/pcp2zabbix/src/GNUmakefile
+++ b/src/pcp2zabbix/src/GNUmakefile
@@ -23,8 +23,8 @@ VERSION_SCRIPT = exports

 LIBTARGET = zbxpcp.$(DSOSUFFIX)
 LLDLIBS = $(PCPLIB)
-ZABBIX_DIR = /var/lib/zabbix
-MODULE_DIR = $(ZABBIX_DIR)/modules
+ZABBIX_DIR = $(PCP_LIB_DIR)/zabbix
+MODULE_DIR = $(ZABBIX_DIR)/agent

 default: $(LIBTARGET)

Thanks,

-- 
Marko Myllynen

<Prev in Thread] Current Thread [Next in Thread>
  • Adjust zbxpcp installation directory, Marko Myllynen <=