pcp
[Top] [All Lists]

Re: [pcp] Introducing pmrep - Performance Metrics Reporter

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] Introducing pmrep - Performance Metrics Reporter
From: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Fri, 27 Nov 2015 14:11:48 +0200
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1393651300.26221829.1448612584520.JavaMail.zimbra@xxxxxxxxxx>
Organization: Red Hat
References: <560278D5.8010305@xxxxxxxxxx> <5603F9D6.7050306@xxxxxxxxxxx> <159724763.42718898.1443163436257.JavaMail.zimbra@xxxxxxxxxx> <560A9715.4060905@xxxxxxxxxx> <1542966539.49294102.1444091627491.JavaMail.zimbra@xxxxxxxxxx> <563099B1.7000802@xxxxxxxxxx> <980961654.65506823.1446187043033.JavaMail.zimbra@xxxxxxxxxx> <565332B4.8040201@xxxxxxxxxx> <1393651300.26221829.1448612584520.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: myllynen@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
Hi,

On 2015-11-27 10:23, Nathan Scott wrote:
> 
> Yeah, its not an issue - I'll look into QA'ing and maybe merging pmrep early
> next week, and you can follow up with smaller delta patches to the master
> branch thereafter if you like.

that would be great, yes.

>> Unless there are any suggestions I'm starting to think that the user
>> interface should be considered stable in that sense that any possible
>> changes should be done without changing the current options and syntax
>> if at all possible.
> 
> Excellent.

Except now that Frank came up with the FetchGroup API, I realized that
we could compress the compact metricspec format even further (by
combining the current unit/scale and raw fields as one, currently their
use is mutually exclusive so should make things more straightforward).

>> The only thing might be the default time format used. It's currently
>> %H:%M:%S but timestamps with microsecond precision would be somewhat
> 
> I think without microseconds will make a good default - most tools tend
> to do this, and that extra precision is only rarely needed (so not worth
> cluttering default reports with usually).

Ok, let's stick with %H:%M:%S.

>> I enhanced the Zabbix reporting so that it can send metrics in batches
>> (in the spirit of zabbix_sender(8)) and it seems to work reliably. The
>> downside on that front is the the zbxsend upstream hasn't responded to
>> my zbxsend / Python 3 patches. One possibility might be to provide
>> pcpzbxsend which would essentially be zbxsend+fixes but I'm not sure
>> would this be optimal.
> 
> OK, yep.  How much code are we talking about, in the zbxsend module?
> (could you send me a pointer?  not sure I have that code handy).

Both the original and the locally fixed versions are ~90 lines of easily
readable code (with BSD license). I've tried to contact the upstream
three times since Oct 20 to no avail. Perhaps we could try one more time
and if no response then use a local copy as long as needed.

https://pypi.python.org/pypi/zbxsend

Cheers,

-- 
Marko Myllynen

<Prev in Thread] Current Thread [Next in Thread>