Hi,
On 2015-11-26 07:22, Mark Goodwin wrote:
> On 11/25/2015 04:48 PM, Frank Ch. Eigler wrote:
>>
>> I have finally made some progress on the "fetchgroup" api extension
>> that we had talked about a year ago and then some [1]. It's starting
>> to come together, and am looking for feedback on design or smaller
>> issues.
>>
>> The work is all on git://sourceware.org/git/pcpfans.git fche/fetchgroup .
>>
>> The core implementation is in libpcp/src/fetchgroup.c; a man page in
>> man/man3/pmfetchgroup.3 with a sample program (below); and adapts
>> src/pmmgr and src/pmclient to the api. QA and fixes are coming. The
>> man page would be a good one to start from. I'd be happy to explain
>> further.
>
> Hi Frank, I like this API - have a few questions and suggestions.
likewise on both, looks like with this a couple of hundred lines of code
from pmrep could be replaced with fetchgroup Python PMAPI calls.
In addition to some minor comments I had on IRC already, perhaps you
could comment these a bit higher level items on the list as well:
- did you consider allowing NULL for out_type to signal native type?
- how would you use the API with non-leaf PMNS nodes?
Thanks,
--
Marko Myllynen
|