pcp
[Top] [All Lists]

Re: [pcp] pcp updates - yippee secure socket connections work

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] pcp updates - yippee secure socket connections work
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 18 Apr 2013 21:18:26 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <516F8AB8.6000807@xxxxxxxxxxxxxxxx>
References: <516F8AB8.6000807@xxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: rO9A1EfmQxid5tWBMxsKrY94PlLiXQ==
Thread-topic: pcp updates - yippee secure socket connections work

----- Original Message -----
> ...
> Since this is ONLY at the core of EVERYTHING in PCP, it would be a good idea
> to have as may knowing eyes look at this particular change as possible and
> be ruthless in your reviewing.

I think we should remove the (timeout == TIMEOUT_ASYNC) case completely.
Its confusing, the tight loop there is dodgey (as per Franks comments),
and the way it peeks inside the PDU buffer to get the size looks highly
questionable as well.

Thoughts?  The only user is the pducheck.c QA test code AFAICT.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>