Some review eyes here would be appreciated.
Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (9):
qa/check-group: add support for tags to explicitly include/exclude groups
libpcp: extend __pmAF* family with __pmAFsetup
pmlogger: change semantics for first logging operation
qa/common.sh: expunge, not used anywhere
qa: many changes for pmlogger "log early" semantic change
configure and headers: add support for strtoint64 macro
src/pmdas/linux/interrupts.c: be consistent about values
src/pmdas/linux/linux_table.c: need to include pcp/config.h for
strto*int64 macro definition
src/pmdas/gfs2/sbstats.c: be consistent about values
config.mingw | 1
configure | 59 +++++++++++++++
configure.ac | 49 ++++++++++++
man/man3/pmaf.3 | 38 +++++++--
qa/032.out | 24 +++---
qa/053 | 10 ++
qa/072 | 2
qa/083.out | 56 +++++++-------
qa/087.out | 18 ++--
qa/088.out | 3
qa/093 | 32 ++++----
qa/093.out | 66 ++++++++---------
qa/102.out | 4 -
qa/1054 | 2
qa/1054.out | 3
qa/1108 | 1
qa/157 | 3
qa/157.out | 1
qa/178 | 4 -
qa/178.out | 2
qa/206.out | 20 ++---
qa/251 | 3
qa/251.out | 5 +
qa/418 | 7 +
qa/418.out | 12 ++-
qa/419.darwin | 72 +++++++++---------
qa/419.irix | 160 +++++++++++++++++++++---------------------
qa/419.linux | 96 ++++++++++++-------------
qa/441 | 1
qa/510 | 1
qa/571 | 1
qa/897.out | 8 +-
qa/919.out | 1
qa/948 | 8 +-
qa/948.out | 3
qa/992 | 7 +
qa/992.out | 18 ++--
qa/GNUmakefile | 2
qa/README.common | 1
qa/check-group | 18 ++++
qa/common.sh | 41 ----------
qa/group | 20 ++---
src/include/pcp/config.h.in | 4 +
src/include/pcp/impl.h | 1
src/libpcp/src/AF.c | 17 +++-
src/libpcp/src/exports | 5 +
src/pmdas/gfs2/sbstats.c | 4 -
src/pmdas/linux/interrupts.c | 5 -
src/pmdas/linux/linux_table.c | 3
src/pmlogger/src/dopdu.c | 3
src/pmlogger/src/gram.y | 54 +++++++++++++-
51 files changed, 594 insertions(+), 385 deletions(-)
Details ...
commit 72a909be3ba431f2e27929d0ba225e5a328ec55c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 17:07:29 2015 +1100
src/pmdas/gfs2/sbstats.c: be consistent about values
Values in this part of the PMDA's code are stored as uint64_t
so make the extraction path consistent (use strtouint64()
not strtoull()).
commit 0849c4abb08b51e49e6fe162f75b54c5379e3748
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 14:58:57 2015 +1100
src/pmdas/linux/linux_table.c: need to include pcp/config.h for strto*int64
macro definition
commit ff341b542539061ec85a2e595ede30677af54c56
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 14:53:55 2015 +1100
src/pmdas/linux/interrupts.c: be consistent about values
Values in this part of the PMDA's code are stored as "long long"
so make the extraction path consistent (use strtoull() and long long
temporary value, not strtoul() and long temporary value).
commit 34794bb8f98ac70037ea7d2adea304a6f0aac0ff
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 14:49:06 2015 +1100
configure and headers: add support for strtoint64 macro
Trying to clean up the code where we call strtol() or strtoll() to
extract a number that is expected to be a 64-bit int (or
unsigned variant thereof). The strtol() use is wrong on 32-bit
platforms. The macros strtoint64() and strtouint64() may be
used where conversion to a 64-bit is explicit and required (e.g.
to enforce an API, or PDU, or archive format constraint).
commit 92c58592924d6f7bbb019148c568d0f7829a0f42
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 14:46:28 2015 +1100
qa: many changes for pmlogger "log early" semantic change
The pmlogger change to go from "log after delta" to "log now and then
after delta" invalidated a bunch of QA ... this commit puts things back
into a passing state.
commit b623dc150e7e30c42a525ba42e24bcf2d1bdd532
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 09:54:52 2015 +1100
qa/common.sh: expunge, not used anywhere
commit c3629454cdd7fbf9593f035461cd92ed024ce94f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 09:01:30 2015 +1100
pmlogger: change semantics for first logging operation
For each group in the configuration file (actually groups in the
configuration file with the same logging frequency are combined),
we used to add the first record to the archive after one logging
period had elapsed.
Now we add the first record for each group as soon as possible (the
log once groups get done first).
The same semantic change is implemented for dyamic changes to logging
activated via pmlc.
These changes mean we have data available earlier in the archive for
both for counter and non-counter metrics.
commit 81b97bc754ffa83bff7f0aca1b097fb8e25ee2fa
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 08:58:50 2015 +1100
libpcp: extend __pmAF* family with __pmAFsetup
Required for a pmlogger change to allow the caller to control
when the first event should be scheduled (the only option
using __pmAFregister() was after one delta time period).
__pmAFsetup() is a simple generalization of __pmAFregister().
commit eb93fec089970b956fcb99ba2ab78a7f063c123d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 15 07:17:23 2015 +1100
qa/check-group: add support for tags to explicitly include/exclude groups
check-groups uses pattern matching to try and validate the contents
of the group file. Unfortunately this sometimes fails because the
command name appears in a context other than executing the command.
The tags line are of the form
<comment> check-group-include: <group> ...
<comment> check-group-exclude: <group> ...
|