On 02/10/15 06:38, Frank Ch. Eigler wrote:
Hi -
Patch pings re. pcpfans.git branches:
fche/pmie (since Sun Aug 23):
commit 84203ee3d8de8055350c41c48919f18959a6b670
pmie-fqdn: support "%c" substitution in action strings
commit 2145353249b5448277f9628b535f604da569b913
pmie-fqdn qa/983: pmie -h test
commit bb96f6be1a53daa6cb94b42e81b40690f339105e
PR1105: fqdn -h support for pmie
I've review these, thanks Frank.
Here are my notes ... nothing major here and I've commit Frank's commits
and a follow-on one to address these issues to my tree.
man/man1/pmie.1
Small editorial change around %c verbage.
src/pcp/src/show.c
In showSyn() should report m->hname not m->hconn for CND_FETCH
or CND_DELAY nodes in the expression tree to match the user's
input rule (remove question in comment).
Change type of findFormat() from int to char and add the default
case for %? (action is to keep searching, which was the implied
but is now explicit).
In showSatisfyingValue()
revert
length = concat("\n<tab> ", length, &string);
to
length = concat("\n<space> ", length, &string);
qa/519 - small tweak for reported hostname than might be a FQDN and
might not
qa/583 - small tweak for reported hostname than might be a FQDN and
might not
qa/622 - needed an updated .out file
qa/294 - number of context connections and disconnections is different
because there are now fewer pmNewContext() calls on the default
context path. Needed an updated .out file.
Cheers, Ken.
|