Main changes here are Frank's, mine and the unrelated NVME change from Intel.
(the ones from Nathan, Lukas, Martins and Michele are not new, just chatter
from my last re-sync with the oss trees ... sorry about this).
Changes committed to git://git.pcp.io/kenj/pcp master
Nathan Scott (11):
python api: add simple debugging interface to access pmDebug
pcp-atop: default pagesize/hertz values for failed fetches
build: update spin-rawhide to gulp-build for vector-git
pmdanfsclient: update comparison to handle string/int
pcp2graphite: be consistent with import handling
pcp-atop: use int flags parameters and correct archive mode
qa: remake 1082 output after most recent ascii/utf changes
qa: make nfsclient test check for perl warnings in pmda logfile
rc_pmcd: add missing dollar sign (else, always container mode)
pmdanfsclient: fix long help text length for qa/469
qa: small test fixes for when pmdapostgres/pmdanginx are active
Ken McDonell (6):
qa/519: tweak filtering after recent pmie change
qa/622: updated output after pmie report format change
qa/583: tweak filtering after recent pmie change
qa/294: track recent pmie changes
src/pmie/show.c: small changes afer FQDN changes
pmie man page: minor wordsmithing around (new) %c format item
Frank Ch. Eigler (3):
PR1105: fqdn -h support for pmie
pmie-fqdn qa/983: pmie -h test
pmie-fqdn: support "%c" substitution in action strings
Lukas Berk (2):
Add qa-notes.txt to webapps files, fix build breakage in fedora
buildbot: update install directories to proper version
Martins Innus (1):
pmdanfsclient: fix typo and a bad regex for couple of metrics
Michele Baldessari (1):
Fix formatting issue in documentation page seen on pcp.io
Suruchi Kadu (1):
linux pmda: add support for NVME devices
build/rpm/fedora.spec | 1
man/html/index.html | 2
man/man1/pmie.1 | 27 -
qa/.gitignore | 1
qa/1082 | 9
qa/1082.out | 758 +++++++++++++++++++++++++++++++++++
qa/1082.out.py2 | 758 -----------------------------------
qa/1082.out.py3 | 758 -----------------------------------
qa/158.out.2 | 2
qa/294.out | 32 -
qa/318.out | 2
qa/321.out | 2
qa/356.out | 4
qa/359 | 2
qa/368 | 2
qa/378.out | 14
qa/433.out | 2
qa/479.out.2 | 4
qa/501-linux.out | 114 ++---
qa/514.out.3 | 2
qa/519 | 16
qa/549.out | 2
qa/556.out | 2
qa/557.out | 4
qa/558.out.irix | 11
qa/558.out.linux | 11
qa/581.out | 16
qa/583 | 26 +
qa/583.out | 6
qa/622.out | 2
qa/667 | 6
qa/733.out.2 | 2
qa/764.out | 4
qa/777.out | 2
qa/785 | 5
qa/785.out | 11
qa/787.out | 2
qa/798 | 19
qa/798.out | 4
qa/922.out | 10
qa/951.out | 4
qa/983 | 112 +++++
qa/983.out | 49 +-
qa/buildbot/master.cfg | 4
qa/common.filter | 1
qa/group | 1
scripts/spin-rawhide | 28 -
src/pcp/atop/atop.h | 4
src/pcp/atop/atopsar.c | 8
src/pcp/atop/parseable.c | 4
src/pcp/atop/parseable.h | 2
src/pcp/atop/showgeneric.c | 4
src/pcp/atop/various.c | 19
src/pcp2graphite/pcp2graphite.py | 32 -
src/pmcd/rc_pmcd | 17
src/pmdas/linux/proc_partitions.c | 15
src/pmdas/nfsclient/pmdanfsclient.pl | 98 ++--
src/pmie/src/dstruct.c | 16
src/pmie/src/dstruct.h | 13
src/pmie/src/eval.c | 11
src/pmie/src/eval.h | 3
src/pmie/src/fetch.sk | 7
src/pmie/src/pmie.c | 41 -
src/pmie/src/pragmatics.c | 164 +++----
src/pmie/src/pragmatics.h | 5
src/pmie/src/show.c | 83 ++-
src/pmie/src/symbol.c | 5
src/pmie/src/symbol.h | 5
src/pmie/src/syntax.c | 35 +
src/python/pcp/pmapi.py | 10
src/python/pmapi.c | 8
71 files changed, 1469 insertions(+), 1996 deletions(-)
Details ...
commit fc8f9b86e39bf29ebc073c427d2a8495ec8e1ebf
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 8 20:05:07 2015 +1100
pmie man page: minor wordsmithing around (new) %c format item
commit 3f9ebb0358790ac256ed18aeb8932979eed3b274
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 8 20:03:51 2015 +1100
src/pmie/show.c: small changes afer FQDN changes
In showSyn() should report m->hname not m->hconn for CND_FETCH
or CND_DELAY nodes in the expression tree to match the user's
input rule (remove question in comment).
Change type of findFormat() from int to char and add the default
case for %? (action is to keep searching, which was the implied
but is now explicit).
In showSatisfyingValue() revert
length = concat("\n<tab> ", length, &string);
to
length = concat("\n<space> ", length, &string);
commit d654b30fec41a1861d689c3c23ba38ff21b1f70c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 8 20:02:18 2015 +1100
qa/294: track recent pmie changes
The number of context connections and disconnections is different
because there are now fewer pmNewContext() calls on the default
context path.
commit 062fda7abed17e2699ac0f8b763426ab5acccb4e
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 8 20:01:07 2015 +1100
qa/583: tweak filtering after recent pmie change
The hostname in the output lines are sensitive to DNS configuration on
the local and remote hosts where pmcd is running ... they may or may
not contain a FQDN ... adjust filter to accommodate both possibilities.
commit d19a4625acb8ae9f5b84529af2b7621d8535bca6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 8 10:53:16 2015 +1100
qa/622: updated output after pmie report format change
commit 8214db66045487fdb39eedb7e4b925e6f1be74ea
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Oct 8 10:49:33 2015 +1100
qa/519: tweak filtering after recent pmie change
The hostname in the output lines are sensitive to DNS configuration
on the remote hosts where pmcd is running ... they may or may not
contain a FQDN ... adjust filter to accommodate both possibilities.
commit ec5e592e7c514a542602fcf53042613fcb046536
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Sun Aug 23 11:55:33 2015 -0400
pmie-fqdn: support "%c" substitution in action strings
Add this peer to "%h" to expose the recently reified
connection-string value.
commit 48ddab879fc5dd3c2350de16dc3288dadc9fac4a
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Sun Aug 23 11:34:14 2015 -0400
pmie-fqdn qa/983: pmie -h test
New test for pmie fqdn functionality, to assert that it will only
connect to a remote host via the -h $CONNSTRING rather than "host
name". Done by suppressing normal pmie; starting at some arbitrary
high address, and for bonus marks also starting a socat relay proxy.
A brief pmie job against these (and a control scenario) is run.
commit 547cb50dd0b739988c81858e9a5346e8caed31c2
Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
Date: Fri Mar 7 21:35:36 2014 -0500
PR1105: fqdn -h support for pmie
pmie's use of host names as interchangeable with pmNewContext
connection strings was deeply embedded. The new fields in structs
'metric' and 'host' track a connection string alongside the host name.
The newContext() function is now solely responsible for looking up
host names from archive or real-time pmcd connections, and updating
the pmie mmv data with it. Some other functions that used to take an
ambiguous name parameter now document which, or else take both.
pmie diagnostic messages try to more consistently print one or the
other, requiring many trivial qa/FOO.out updates.
In the man page, pmie's -H (don't do dns lookup) became undocumented,
since it has long been unimplemented. A little bit of clarification
regarding host names vs connection strings was added.
Some const qualifiers to char*'s have been added,
out of a sense of unchanging constervativeness.
commit 30e4fe45b73715a6f7ede02fbaf6ff592fe97410
Author: Suruchi Kadu <suruchi.a.kadu@xxxxxxxxx>
Date: Thu Oct 8 07:03:11 2015 +1100
linux pmda: add support for NVME devices
Patch from Intel.
Handle NVME device partition names like nvme0n1p1 using the
same recipe as the other SSD ones, "ram...", "mmcblk...", etc.
commit 899a7f8b38665894740576d8de55801b81c0b261
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Oct 7 17:04:30 2015 +1100
qa: small test fixes for when pmdapostgres/pmdanginx are active
commit eb8133b40c4721c17d2e426d1d5685575d63527f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Oct 7 17:03:32 2015 +1100
pmdanfsclient: fix long help text length for qa/469
commit 4d4d6195d78836043d9c0b1cc26a044fd72b76d3
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Oct 7 17:02:56 2015 +1100
rc_pmcd: add missing dollar sign (else, always container mode)
While fixing up this little regression, make the scripting the
same as the equivalent rc_pmlogger/rc_pmie code such that this
kind of accidental difference stands out more.
commit 3624a159ced2a1e85894beb30b7021d5f18a4fbb
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Oct 7 16:17:48 2015 +1100
qa: make nfsclient test check for perl warnings in pmda logfile
commit 3a73d7fac87a5efd87b48ac6a5921a1ef9d89ddc
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Wed Oct 7 16:16:50 2015 +1100
pmdanfsclient: fix typo and a bad regex for couple of metrics
commit 5d1994caa164cdde46c84a89610a9e492b3444c1
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Oct 7 15:47:30 2015 +1100
qa: remake 1082 output after most recent ascii/utf changes
commit a607d36d0ecc600358e7cc5755fe395defa40b0f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Oct 7 15:32:57 2015 +1100
pcp-atop: use int flags parameters and correct archive mode
Ken picked up a failure of qa/785 (atopsar) and investigation
suggests the flags parameter int/char use may be causing the
failure, as well as a definite bug in the PMAPI log scanning
mode previously being used in pcp-atop[sar].
commit c72f16caf73086ec4f39a7afc6fca997e11d1d5c
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Tue Oct 6 13:57:13 2015 -0400
buildbot: update install directories to proper version
commit d82888c11d2acfdc843c60d0d7974aab144da585
Author: Michele Baldessari <michele@xxxxxxxxxx>
Date: Tue Oct 6 13:48:27 2015 -0400
Fix formatting issue in documentation page seen on pcp.io
commit f013807a8df7ad16d6798a1f47e8a3caf26cd8e8
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Tue Oct 6 13:46:08 2015 -0400
Add qa-notes.txt to webapps files, fix build breakage in fedora
commit 0ec7536b198da88c7f4a6c22ef2d85bbb8fe88ed
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Oct 6 16:22:10 2015 +1100
pcp2graphite: be consistent with import handling
Noticed some inconsistencies in handling of module imports
in pcp2graphite, particularly cpmapi/c_api. Probably just
atrophied over time; picked one and used it throughout.
commit b926064a0845f3d42666da2dbd1bee1c6f96b746
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Oct 6 16:15:22 2015 +1100
pmdanfsclient: update comparison to handle string/int
Martins reported an string-to-integer comparison exception
from pmdanfsclient, resulting from earlier changes to send
integer error codes back to clients correctly. QA actually
tests this case so not 100% sure this will fix the problem,
but lets give it a crack.
commit c6b5cca3d8dac6a6ba7f6e38daf9dfb7bb74e5ac
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Oct 6 16:12:31 2015 +1100
build: update spin-rawhide to gulp-build for vector-git
commit 8d84c3ccb8c36fad48c0b943b33218c14d18b876
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Oct 6 16:10:28 2015 +1100
pcp-atop: default pagesize/hertz values for failed fetches
If these metrics are not available (eg not logged), we'll
take a sigfpe due to division by zero - provide a default
value for each in this case (so we can fail more cleanly,
later on, most likely)... tackles one part of a problem
Ken's discovered running QA.
commit c541b99debddef7e7cba4ca4419d4905b8b4bd75
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Oct 6 16:07:31 2015 +1100
python api: add simple debugging interface to access pmDebug
Add a read-only interface for checking libpcp pmDebug state into
the python API. So far, just export constants for APPL0,APPL1,
and APPL2 flags since thats all python scripts should ever need.
Update pcp2graphite to handle -D option more like the C tools -
instead of overriding -D such that any use enables local debug,
it now handles pmDebug setting a bit more like nature intended
(e.g. -D PDU,APPL0 and/or just -DPDU).
While in there, replaced "hack to include some explanatory text"
with use of the interface designed for that purpose.
Updated test qa/667 to test it out.
|