pcp
[Top] [All Lists]

[PATCH] ds389: return correct error code on connection failures

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: [PATCH] ds389: return correct error code on connection failures
From: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Wed, 7 Oct 2015 11:43:46 +0300
Delivered-to: pcp@xxxxxxxxxxx
Organization: Red Hat
Reply-to: myllynen@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
Return correct error code to clients when not connected.

---
 src/pmdas/ds389/pmdads389.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/pmdas/ds389/pmdads389.pl b/src/pmdas/ds389/pmdads389.pl
index 60b4ed2..19d8893 100644
--- a/src/pmdas/ds389/pmdads389.pl
+++ b/src/pmdas/ds389/pmdads389.pl
@@ -129,6 +129,7 @@ sub ds389_fetch {
 sub ds389_fetch_callback {
        my ($cluster, $item, $inst) = @_;
 
+       if (!defined($ldap))            { return (PM_ERR_NOTCONN, 0); }
        if ($inst != PM_INDOM_NULL)     { return (PM_ERR_INST, 0); }
 
        my $pmnm = pmda_pmid_name($cluster, $item);

Thanks,

-- 
Marko Myllynen

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] ds389: return correct error code on connection failures, Marko Myllynen <=