pcp
[Top] [All Lists]

Re: [pcp] QA failures - pmlogrewrite

To: pcp@xxxxxxxxxxx
Subject: Re: [pcp] QA failures - pmlogrewrite
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu, 1 Oct 2015 20:41:20 +1000
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <560950E3.5000907@xxxxxxxxxxx>
References: <1634182203.44189149.1443431812071.JavaMail.zimbra@xxxxxxxxxx> <560950E3.5000907@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
On 29/09/15 00:38, Martins Innus wrote:
Nathan,

On 9/28/15 5:16 AM, Nathan Scott wrote:
Hi Martins,

I'm seeing some recent QA regressions in pmlogrewrite tests, which
I'm guessing relate to the changes from end of last week.  Could
you take a look, and/or pass back to me/Ken (I'm away for most of
of this week - can take a look when I get back though, if needed).


Sorry about that.  Looks like TOK_ASSIGN was now binding to the new
pattern that allowed in broken metric names.  Patch below tries to
ensure that dash and equals are followed by an alphanumeric.

Patch looks good Martins.  This resolves all my pmlogextract QA failures.

I've committed to my tree (with an explanatory comment).

Thanks, Ken.

<Prev in Thread] Current Thread [Next in Thread>