[PATCH] Adjust few ds389 metric types

[Marko Myllynen <myllynen@xxxxxxxxxx>]

Hi,

while working for 389 DS 1.3.3 / RHDS 10 support, I noticed types
which should be adjusted. The max* changes should be obvious, the
readonly metric type/unit now matches filesys.readonly although I
wonder would PM_SEM_DISCRETE be more appropriate for both of them.

---
 src/pmdas/ds389/pmdads389.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/pmdas/ds389/pmdads389.pl b/src/pmdas/ds389/pmdads389.pl
index 4fa4fa2..8a40076 100644
--- a/src/pmdas/ds389/pmdads389.pl
+++ b/src/pmdas/ds389/pmdads389.pl
@@ -183,7 +183,7 @@ $pmda->add_metric(pmda_pmid(0,11), PM_TYPE_U32, 
PM_INDOM_NULL,
 
 # cn=monitor,cn=userRoot,cn=ldbm database,cn=plugins,cn=config
 $pmda->add_metric(pmda_pmid(1,0), PM_TYPE_U32, PM_INDOM_NULL,
-               PM_SEM_DISCRETE, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
+               PM_SEM_INSTANT, pmda_units(0,0,0,0,0,0),
                'ds389.userroot.readonly', '', '');
 $pmda->add_metric(pmda_pmid(1,1), PM_TYPE_U64, PM_INDOM_NULL,
                PM_SEM_COUNTER, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
@@ -204,7 +204,7 @@ $pmda->add_metric(pmda_pmid(1,6), PM_TYPE_U32, 
PM_INDOM_NULL,
                PM_SEM_INSTANT, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
                'ds389.userroot.currententrycachecount', '', '');
 $pmda->add_metric(pmda_pmid(1,7), PM_TYPE_32, PM_INDOM_NULL,
-               PM_SEM_DISCRETE, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
+               PM_SEM_INSTANT, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
                'ds389.userroot.maxentrycachecount', '', '');
 $pmda->add_metric(pmda_pmid(1,8), PM_TYPE_U64, PM_INDOM_NULL,
                PM_SEM_COUNTER, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
@@ -225,7 +225,7 @@ $pmda->add_metric(pmda_pmid(1,13), PM_TYPE_U32, 
PM_INDOM_NULL,
                PM_SEM_INSTANT, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
                'ds389.userroot.currentdncachecount', '', '');
 $pmda->add_metric(pmda_pmid(1,14), PM_TYPE_32, PM_INDOM_NULL,
-               PM_SEM_DISCRETE, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
+               PM_SEM_INSTANT, pmda_units(0,0,1,0,0,PM_COUNT_ONE),
                'ds389.userroot.maxdncachecount', '', '');
 
 $pmda->set_refresh(\&ds389_fetch);

Thanks,

-- 
Marko Myllynen