Linux PMDA one is probably review-worthy.
Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (3):
configure: tweak PAPI_CFLAGS and PAPI_LIBS logic
linux pmda et al: printf support for int64_t (or uint64_t)
qa/975: notrun for old versions of iostat
configure | 40 ++++++++++++++++++++++++++++---------
configure.ac | 39 +++++++++++++++++++++++++++---------
qa/975 | 14 ++++++++++++
src/include/pcp/platform_defs.h.in | 1
src/pmdas/linux/proc_net_softnet.c | 31 ++++++++++++++++++++++++----
5 files changed, 103 insertions(+), 22 deletions(-)
Details ...
commit e24425061402cfc746f5b7a313c6dabd77923ecd
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Aug 15 08:59:18 2015 +1000
qa/975: notrun for old versions of iostat
commit 1888c977cd4c0cd3fb172b24a7cd0308d9ebaaa6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Aug 13 20:28:01 2015 +1000
linux pmda et al: printf support for int64_t (or uint64_t)
Turns out that the "softnet" metrics in the linux PMDA generate
compilation warnings on some platforms because "%lx" is not the
the correct format for an argument of type uint64_t.
Fixing this requires:
1. more configure glue, along the lines of FMT_PID and FMT_PTHREAD, so
now we have FMT_INT64 ("lld" or "ld")
2. building the sscanf() format at runtime in the linux PMDA for
the network.softnet metrics.
commit 86bdc78e08056519ea09a7af4bfc848c6434878f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Aug 13 06:40:57 2015 +1000
configure: tweak PAPI_CFLAGS and PAPI_LIBS logic
These should be the _extra_ stuff needed for PAPI (if any), rather
than all the gcc/ld options.
|