It would be most beneficial to have someone more skilled at Perl than I review
the postgresql PMDA changes ... there is some major surgery therein.
Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (9):
dstrun PMDA: fix parethesis botch in Perl code
pmdbg: add -D option
linux pmda: tweak (don't) HAVE_SETNS code block
postgresql PMDA: major overhaul
qa/admin/check-vm: add checks for perl bits needed for postgresql
qa misc: update installed makefiles so "clean" target defined
qa/qt: change installed makefiles so rebuild is not attempted
qa: do not install GNUmakefile.install files
postgresql PMDA: remove an old TODO note
man/man1/pmdbg.1 | 16 +
qa/778 | 222 ++++++++++++++
qa/778.out | 38 ++
qa/GNUmakefile | 4
qa/admin/check-vm | 4
qa/archives/GNUmakefile | 2
qa/cifs/GNUmakefile.install | 2
qa/json/GNUmakefile.install | 2
qa/linux/GNUmakefile.install | 2
qa/pconf/cpu/GNUmakefile.install | 2
qa/pconf/disk/GNUmakefile.install | 2
qa/pconf/filesys/GNUmakefile.install | 2
qa/pconf/global/GNUmakefile.install | 2
qa/pconf/memory/GNUmakefile.install | 2
qa/pconf/network/GNUmakefile.install | 2
qa/perl/GNUmakefile.install | 3
qa/postfix/GNUmakefile.install | 2
qa/qt/qmc_context/GNUmakefile.install | 11
qa/qt/qmc_desc/GNUmakefile.install | 11
qa/qt/qmc_dynamic/GNUmakefile.install | 11
qa/qt/qmc_event/GNUmakefile.install | 11
qa/qt/qmc_format/GNUmakefile.install | 11
qa/qt/qmc_group/GNUmakefile.install | 11
qa/qt/qmc_hosts/GNUmakefile.install | 11
qa/qt/qmc_indom/GNUmakefile.install | 11
qa/qt/qmc_metric/GNUmakefile.install | 11
qa/qt/qmc_source/GNUmakefile.install | 11
qa/views/GNUmakefile.install | 2
src/pmdas/dtsrun/pmdadtsrun.pl | 2
src/pmdas/linux/namespaces.c | 7
src/pmdas/postgresql/pmdapostgresql.pl | 501 ++++++++++++++++++++++++++++++---
src/pmdbg/pmdbg.c | 14
32 files changed, 826 insertions(+), 119 deletions(-)
Details ...
commit 080c406b640d9c12b9e7065f06ee08229b2cd87f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 19:47:46 2015 +1000
postgresql PMDA: remove an old TODO note
commit bad591f59022b8e2e16c99e65daac87e83534bdc
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 19:44:27 2015 +1000
qa: do not install GNUmakefile.install files
In the installed testsuite directory the GNUmakefile files come
from the GNUmakefile.install files from the source ... should
never have GNUmakefile and GNUmakefile.install for the same
directory from the packages.
commit 74aa3bd689d0cba98b129bb2dbccfa5c4465c2e5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 19:41:26 2015 +1000
qa/qt: change installed makefiles so rebuild is not attempted
If Qt is available, the binaries are shipped in the pcp-testsuite
package and cannot be rebuilt insitu because the headers and
static library from the build are not packaged.
commit 1ca777d31b496fcfa50963fad2ab32e37dd770eb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 19:40:33 2015 +1000
qa misc: update installed makefiles so "clean" target defined
commit 1d1f0f7de8b7f67cb993cf9843e4a776c28d3649
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 08:27:47 2015 +1000
qa/admin/check-vm: add checks for perl bits needed for postgresql
commit a23501f1ff39e19aaff497890a4c911778cc878a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 07:28:36 2015 +1000
postgresql PMDA: major overhaul
The stats views have different schemas in different versions of
postgresql ... sometimes radically so with missing columns and
added columns, and there is no attempt to add new columns at the
end of the views.
So we need a more general mapping mechanism to find the columns
we're searching for.
Also update the QA coverage in qa/778.
commit 71163c4f0292e8b8328c1a7c79fd0230fd4e508a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 07:26:25 2015 +1000
linux pmda: tweak (don't) HAVE_SETNS code block
Since the call to close_namespace_fds() is now guarded, we don't
need a dummy implementation in the code block for the case where
the platform does not support setns().
commit e15f398d4f19a457a289957f4475af09fb421153
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 07:24:23 2015 +1000
pmdbg: add -D option
Parses -D flag[,flag ...] and reports the corresponding decimal
value.
Personal itch, useful when wanting to set pmDebug using gdb.
commit 58f12672a914e5b51162e43701c78977e70fac6c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 15 07:23:34 2015 +1000
dstrun PMDA: fix parethesis botch in Perl code
|