pcp
[Top] [All Lists]

Re: QA build breakage for pcp-testsuite installs

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: QA build breakage for pcp-testsuite installs
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed, 15 Jul 2015 17:23:38 +1000
Cc: pcp <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <111439666.38947696.1436931908240.JavaMail.zimbra@xxxxxxxxxx>
References: <111439666.38947696.1436931908240.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
On 15/07/15 13:45, Nathan Scott wrote:
Hi Ken,

Just a heads up that I still see occasional build breakage with
master branch for QA runs inside /var/lib/pcp/testsuite  ...

Not supposed to happen (even though I rarely/never test this way).

... I tend to do a "make setup" after install (to
create archives and so on, then run "check"), and get this ...

gmake: GNUmakefile.install: No such file or directory
gmake: *** No rule to make target `GNUmakefile.install'.  Stop.
Warning: pmdas/broken: /usr/bin/gmake -f GNUmakefile.install broken_v2.dir 
failed

Hmm ... for me ...

kenj@bozo:~$ sudo -u pcpqa bash
pcpqa@bozo:~$ cd /var/lib/pcp/testsuite
pcpqa@bozo:/var/lib/pcp/testsuite$ make setup
PATH=.:/home/kenj/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/kenj/src/pcp/qa/admin:/usr/lib/pcp/bin; ./mk.qa_hosts
200+0 records in
400+0 records out
...
sample.dodgey.control old value=5 new value=-1044
sample.dodgey.control old value=-1044 new value=5
pcpqa@bozo:/var/lib/pcp/testsuite$

All works fine ... so we're left with a difference between your setup and mine ... would you have run make clean before make setup by any chance?

Seems unlikely ... 8^(>

=== cpu ===
make[2]: *** No rule to make target 'clean'.  Stop.
/usr/include/pcp/buildrules:145: recipe for target 'clean' failed

Which is another problem!  I fixes for this also.

But there should be no GNUmakefile.install files, nor references to GNUmakefile.install in the files below /var/lib/pcp/testsuite that is not guarded by a [ -f GNUmakefile.install ].

pcpqa@bozo:/var/lib/pcp/testsuite$ find . -name GNUmakefile.install
./GNUmakefile.install
./archives/GNUmakefile.install

These are both wrong.  I have fixes for both, but not yet committed.

OTOH, if I do a default "make", I see ...

$ make
qmc_context.cpp:6:25: fatal error: qmc_context.h: No such file or directory
  #include <qmc_context.h>
                          ^
compilation terminated.
make[3]: *** [qmc_context.o] Error 1

This is a yet another problem. There is no way to build any of the binaries below qa/qt in the testsuite dir (we don't have the required headers and libraries as they are not packaged). I have fixes for this as well.


Probably still some quirks of the GNUmakefile.install everywhere that need to
be ironed out?  I'm also find the new make quietness (not showing subdirs as
it descends) makes diagnosing these issues trickier than it used to be.

Well if it worked, there would be no debugging and terseness would be good! Let's try to get there.

<Prev in Thread] Current Thread [Next in Thread>