pcp
[Top] [All Lists]

Re: [pcp] configure.ac issue

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, PCP <pcp@xxxxxxxxxxx>
Subject: Re: [pcp] configure.ac issue
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon, 06 Jul 2015 12:49:16 +1000
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <559661D1.6060905@xxxxxxxxxxxxxxxx>
References: <559661D1.6060905@xxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
On 07/03/2015 08:20 PM, Ken McDonell wrote:
./configure: line 3943: test: too many arguments
./configure: line 3971: test: too many arguments
./configure: line 4011: test: too many arguments

lines like this ... in configure.ac are not syntactically correct, expecially
when $cc_is_gcc appears to be undefined.

     test $cc_is_gcc -a "x$enable_ssp" != xno


I guess the minimal patch would be to quote $cc_is_gcc e.g.
  test "$cc_is_gcc" -a "x$enable_ssp" != xno

so the first part of the test will only succeed if $cc_is_gcc is defined.

Not sure where this worked, but probably needs guidance from Nathan as to the
intent.

not sure where/how $cc_is_gcc became undefined, is that only some platforms?
In any case, I looked over your patch and it looks OK, superficially anyway,
so I'll merge that in from your tree and we'll get Nathan to demystify when he
gets back.

Cheers
-- Mark

<Prev in Thread] Current Thread [Next in Thread>