On 06/12/2015 12:36 PM, Nathan Scott wrote:
Hi guys,
----- Original Message -----
On 12/06/15 06:22, Lukas Berk wrote:
... The other major
difference is where the various config files should be shipped (such as
pmieconf/ and pmlogconf/ files, that coincide with no split-pmdas).
Makepkgs ships them in the pmda-foo packages, and fedora ships them in
the base pcp package. Which do people think is correct?
If possible, these should be in the base PCP package.
I've update pcp.spec.in to handle this.
thanks for that - I've got a bunch of commits to the fedora.spec coming
too - starting with my patch from last night, then Lukas' patch, and
then a few more - I'll push all this out at the end of my day so Lukas
gets some time for more review and followup. I'm doing one commit per
change so it's easier to review.
further down the track - I think we're going to have to change
how the the fedora spec works - the packaging lists need to be
generated by the build rather that by convoluted scriptlets in the
spec itself. that way each target in the manifest gets to specify
where it ends up (e.g. via an extra argument in the $(INSTALL) rule),
and then all the spec has to do is use the resulting lists for the
%files for each package.
I'll look into this for the future ... not this release though.
Cheers
|