Lukas,
I pulled these into my tree, ran QA (67,1782,216,974, -g pmda.proc and
-g pmda.linux) on a x86_64 system and reviewed the code.
All the QA passes ... that's good.
A couple of comments on the code ...
If PROC_PAGESIZE and LINUX_PAGESIZE are _only_ for QA testing, then I
think it would be worth adding a comment to this effect in the PMDA
source code, and perhaps changing the env varnames to
PCPQA_PROC_PAGESIZE and PCPQA_LINUX_PAGESIZE to make it clearer and
further reduce the probability of an unintended name clash in a
production environment.
If these are for something other than QA I don't understand how or when
they might be used, and the explanation probably warrants inclusion in
the man pages.
Otherwise, looks good ... thanks.
On 11/06/15 11:19, Lukas Berk wrote:
Hi,
Please see git://pcp.io/lberk/pcp.git for a variety of qa fixes, several
focused on 64bit arm hardware.
...
|