pcp
[Top] [All Lists]

Re: [pcp] pcp updates - make json PMDA build conditional

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, pcp@xxxxxxxxxxx
Subject: Re: [pcp] pcp updates - make json PMDA build conditional
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Sun, 07 Jun 2015 15:59:19 +1000
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <5573D9D2.1060802@xxxxxxxxxxxxxxxx>
References: <5573C05F.1030901@xxxxxxxxxxxxxxxx> <5573CF48.1080008@xxxxxxxxxx> <5573D9D2.1060802@xxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
On 06/07/2015 03:42 PM, Ken McDonell wrote:

The dupnames ones are all passing for me ... have you Remove'd and Install'ed
the sample PMDAs.

I'll try that, thanks.


I would not expect to see changes for 119, 581 nor 781 ... they are all passing
for me on all platforms where I can run QA.

hmm. that's strange - are you running with this following commit :

commit f6e3da702b16f00cc467e0cf8799c51aaceb7a27
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Tue Jun 2 19:56:13 2015 +1000

    Use full path to pmlogger in pmlogger_check.

    In a container, the PATH has $PCP_SHARE_DIR/lib ahead of $PCP_BINADM_DIR,
    so trying to run "pmlogger" in pmlogger_check is going to relaunch the
    rc script (recursively). Using the full path to $PCP_BINADM_DIR/pmlogger
    in pmlogger_check fixes it.

        modified:   src/pmlogger/pmlogger_check.sh

Note: 581 is only failing because my system has an sdcard mounted (mmcblk0).
But 781 and 119 seem to me to be failing due to the above commit.


pmnewlog arguments is more likely to be a cosmetic regression caused by me
editing the usage text.

ok I'll wait for those to be remade at some point (let me know if you want
me to).

Also note: there should be no build infrastruture issues affecting qa due
to the containers work - build/containers is not integrated into the build.
[But there are a couple of changes in pmlogger_check and pmlogger/ports.c]

Cheers

<Prev in Thread] Current Thread [Next in Thread>