pcp
[Top] [All Lists]

Re: [pcp] pcp updates - make json PMDA build conditional

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, pcp@xxxxxxxxxxx
Subject: Re: [pcp] pcp updates - make json PMDA build conditional
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Sun, 07 Jun 2015 14:57:44 +1000
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <5573C05F.1030901@xxxxxxxxxxxxxxxx>
References: <5573C05F.1030901@xxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
Hi Ken, I'll pull this in for review and merge.

I also have qa fixes for 119, 781 and 581. And probably more too since many of
the failures I'm seeing are due to sample.dupnames metrics (possibly a config
issue in my setup), and also pmnewlog arguments (not investigated yet).

I'll get these fixes merged asap.

Cheers

On 06/07/2015 01:54 PM, Ken McDonell wrote:
For reference, this is how I think we should accommodate dependencies on 
external packages that may not be uinversally available.

It is much better to build and package to completion, possibly with some 
functionality missing or disabled, than it is to have the build die.


Changes committed to git://git.pcp.io/kenj/pcp master

Ken McDonell (4):
       qa/admin/check-vm: update dependency tests based on recent build issues
       json pmda: make build and packaging conditional
       json PMDA: rpm pcp.spec file tweak
       json PMDA: change Requires for python3

  build/rpm/GNUmakefile    |    1
  build/rpm/pcp.spec.in    |   22 +++++++++++++++----
  configure                |   53 
+++++++++++++++++++++++++++++++++++++++++++++++
  configure.ac             |   36 +++++++++++++++++++++++++++++++
  qa/admin/check-vm        |   19 ++++++++--------
  src/include/builddefs.in |    5 ++++
  src/pmdas/GNUmakefile    |    5 +++-
  7 files changed, 126 insertions(+), 15 deletions(-)

Details ...

commit d0426debcf28f88bd4230f8c2a5c22b9c3e3c4e7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Jun 7 13:49:37 2015 +1000

     json PMDA: change Requires for python3

     I don't believe there is a python3-jsonpointer rpm ... at least not
     on many of my QA platforms.

     Should be Requires python-jsonpointer for either python2 or python3.

commit 7b6a7c0584b959b2970d875939e67aff0b622861
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Jun 7 13:47:59 2015 +1000

     json PMDA: rpm pcp.spec file tweak

     Forgot pcp.spec.in not used by configure, need hand crafted rule
     in GNUmakefile to generate pcp.spec, this time with correct
     expansion for @pmda_json@.

commit f594ca1b241996ce4bf23f0128b8d896c2a2b703
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Jun 7 13:10:09 2015 +1000

     json pmda: make build and packaging conditional

     The json PMDA requires some Python modules that are not universally
     available, so this commit captures that fact and makes the building
     an packaging of the json PMDA conditional on the availability of
     the required Python modules in the build environment.

     Tested on Ubuntu 15.04 with and without the python-json-pointer
     package installed and on Fedora 17 where the python-jsonpointer rpm
     is not available and on RHEL 7.1 with python-jsonpointer installed.

commit 7c9b0205a42d63445832aae9bd67d18428d8bc7b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Jun 7 10:20:37 2015 +1000

     qa/admin/check-vm: update dependency tests based on recent build issues

_______________________________________________
pcp mailing list
pcp@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/pcp


<Prev in Thread] Current Thread [Next in Thread>