Mostly building on Martins' earlier "time type" changes for the linux
proc pmda.
Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (12):
qa/src/pducrash.c: plug small mem leak
pmlogextract: one additional corner case for -d
jbd2 pmda: add pmlogrewrite support for KERNEL_ULONG metrics
jbd2 pmda: add jbd2_kernel_ulong.conf to .gitignore
linux pmda: fix up types for some disk i/o metrics
linux pmda: add pmlogrewrite support for KERNEL_ULONG metrics
linux pmda: add pmlogrewrite clause for disk.dm.total
linux_proc pmda: small help text change
linux_proc pmda: cleanup up the jiffies -> msec calculations
linux_proc pmda: add pmlogrewrite support for KERNEL_ULONG and
jiffy-based metrics
linux_proc pmda: add missing file mk.rewrite
debian: packaging issue ... missing pmGetOptionalConfig.3.gz entry
EC2 Default User (1):
libpcp_pmda: Fixed a memory leak detected by valgrind.
Mark Goodwin (1):
Fix NAME section in pmiostat man page.
Martins Innus (1):
Fixup some of the time types in linux_proc
debian/libpcp3-dev.install | 1
man/man1/pmiostat.1 | 2
qa/src/pducrash.c | 1
src/libpcp_pmda/src/mainloop.c | 2
src/pmdas/jbd2/.gitignore | 1
src/pmdas/jbd2/GNUmakefile | 11 ++--
src/pmdas/jbd2/mk.rewrite | 36 +++++++++++++
src/pmdas/linux/.gitignore | 1
src/pmdas/linux/GNUmakefile | 12 ++--
src/pmdas/linux/convert.h | 2
src/pmdas/linux/mk.rewrite | 63 +++++++++++++++++++++++
src/pmdas/linux/pmda.c | 32 +++++------
src/pmdas/linux/proc_partitions.c | 24 ++++----
src/pmdas/linux_proc/.gitignore | 4 +
src/pmdas/linux_proc/GNUmakefile | 10 ++-
src/pmdas/linux_proc/help_text.h | 4 -
src/pmdas/linux_proc/mk.rewrite | 52 +++++++++++++++++++
src/pmdas/linux_proc/pmda.c | 103
++++++++++++++++++++++----------------
src/pmlogextract/pmlogextract.c | 9 ++-
19 files changed, 284 insertions(+), 86 deletions(-)
Details ...
commit 04fe8ac311d6c3c224288abd65a01e3a03b1493d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 11:43:06 2015 +1000
debian: packaging issue ... missing pmGetOptionalConfig.3.gz entry
Missing from the manifest for libpcp3-dev.
commit 4686004759188c1ec192fe7a870588d86d2d0796
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 09:43:55 2015 +1000
linux_proc pmda: add missing file mk.rewrite
Should have been part of previous commit.
commit 59bdfd460902c2b5924114b19041ab779cb6efd3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 09:41:35 2015 +1000
linux_proc pmda: add pmlogrewrite support for KERNEL_ULONG and
jiffy-based metrics
Because the PCP type of the KERNEL_ULONG metrics is not constant
across platforms, it helps to provide pmlogrewrite rules to ensure
the type is correct, e.g. for archives that may have come from
an older platform environment (32-bit) when processed in a newer
platform environment (64-bit).
Also capture some recent metadata changes in the jiffy-based metrics.
commit 9bf8718bbbd8849127edd6886d9d1819bdb8c45b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 09:41:07 2015 +1000
linux_proc pmda: cleanup up the jiffies -> msec calculations
commit 5bd2216b329035551eb82978ec480410b4dba6a7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:35:55 2015 +1000
linux_proc pmda: small help text change
Change "in miliseconds" (sic) to "(in ms)" to match other
entries.
commit 4b6e2689235c3202b15b24493c3e6ea7df73194a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:32:13 2015 +1000
linux pmda: add pmlogrewrite clause for disk.dm.total
Should be PM_TYPE_U64 on all platforms.
commit 5ee887dcc24f7c6f3a4ffaae58f5ffffdf0f7238
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:28:35 2015 +1000
linux pmda: add pmlogrewrite support for KERNEL_ULONG metrics
Because the PCP type of these metrics is not constant across
platforms, it helps to provide pmlogrewrite rules to ensure
the type is correct, e.g. for archives that may have come from
an older platform environment (32-bit) when processed in a
newer platform environment (64-bit).
commit 656cec37a42d05f337b893bd992e77177f4ac14d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:16:51 2015 +1000
linux pmda: fix up types for some disk i/o metrics
Several metrics shold have been of the platform-specific type
KERNEL_ULONG.
+ disk.dev.blkread and disk.dev.blkwrite were PM_TYPE_U64
+ disk.partitions.read, disk.partitions.write,
disk.partitions.blkread and disk.partitions.blkwrite were
PM_TYPE_U32
+ disk.dm.blkread and disk.dm.blkwrite were PM_TYPE_U64
And disk.dm.total was KERNEL_ULONG but should have been
PM_TYPE_U64.
pmlogrewrite support for these changes is in the next commit.
commit 48cd9beda20b026e17abc4bd2ce4d723fc9c9d47
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:14:44 2015 +1000
jbd2 pmda: add jbd2_kernel_ulong.conf to .gitignore
commit a6935736d144d68bb4710bd36e75e63b963a0adb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 11:33:36 2015 +1000
jbd2 pmda: add pmlogrewrite support for KERNEL_ULONG metrics
Because the PCP type of these metrics is not constant across
platforms, it helps to provide pmlogrewrite rules to ensure
the type is correct, e.g. for archives that may have come from
an older platform environment (32-bit) when processed in a
newer platform environment (64-bit).
commit 624f532b7e7311f2601aba364ec6830a3cdea576
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 06:35:19 2015 +1000
pmlogextract: one additional corner case for -d
If one of the input archives is truncated, then pmGetArchiveEnd()
may fail ... this is not fatal (when -d is specified) so processing
should continue.
commit f4c208ca0f66d7bbc7b23ac14615654a266ca096
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed May 20 11:14:24 2015 +1000
Fix NAME section in pmiostat man page.
modified: man/man1/pmiostat.1
commit f3651868be5c9495382270016d4cd604a6a6bca0
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu May 14 19:39:32 2015 +0000
Fixup some of the time types in linux_proc
Some metrics were reporting as seconds when they were not. Fix
them to be msec as appropriate.
Some metrics with type KERNEL_ULONG had some explcit uint32
conversions. Try to generalize.
commit 22e71855d99b448226d40e793c9eb43e36d963d6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun May 17 17:04:59 2015 +1000
qa/src/pducrash.c: plug small mem leak
From __pmDecodeNameList() analysis after libpcp_pmda patch.
commit 441de74781e4313b750760ec3e48eb34580f99e6
Author: EC2 Default User <ec2-user@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri May 15 21:01:18 2015 +0000
libpcp_pmda: Fixed a memory leak detected by valgrind.
|