There are still a couple more containers fixes coming after the
scaling analysis, but I wanted to get this lot merged first.
Changes committed to git://git.pcp.io/pcp.git master
Ken McDonell (10):
man/man1/pminfo.1: tidy up wording around -n and -N
libpcp/pmns.c: small duplicate names fix
pmnsmerge: small duplicates in PMNS changes
qa/772: (new) exercise duplicate options of pmnsmerge
qa/771: oops, add missing 771.out
qa/235: new .out after recent pmnsmerge changes
pmdaproc.sh: rework
man/pmda.3: document the hidden variables in pmdaproc.sh
qa/pmdas/slow and slow_python: replace deprecated variables
qa/555: improve stability
Nathan Scott (5):
pmdalinux: fix container issues, especially with networking metrics
qa: fix typo in an error message in test 540
build: extend gitignore file set for pmdaroot
pmdaroot: fix race and segv with short-lived containers
build: update mac plist properties, attempt an appnap workaround
Mark Goodwin (1):
Add some additional DBG_TRACE_ATTR debug printfs for values->uptodate.
man/man1/pminfo.1 | 4
man/man1/pmnsmerge.1 | 32 ++
man/man3/pmda.3 | 428 ++++++++++++++++++++++++++++++++-----
qa/042 | 82 +++++++
qa/042.out | 24 ++
qa/047 | 88 +++++++
qa/047.out | 7
qa/235.out | 4
qa/540 | 2
qa/555 | 18 -
qa/771.out | 6
qa/772 | 171 ++++++++++++++
qa/772.out | 45 +++
qa/GNUmakefile | 2
qa/common.docker | 52 ++++
qa/group | 6
qa/pmdas/slow/Install | 2
qa/pmdas/slow_python/Install | 2
src/libpcp/src/pmns.c | 3
src/pmcd/pmdaproc.sh | 459 ++++++++++++++++++++--------------------
src/pmchart/pmchart.info.in | 4
src/pmdas/linux/filesys.c | 10
src/pmdas/linux/filesys.h | 3
src/pmdas/linux/namespaces.c | 42 ++-
src/pmdas/linux/namespaces.h | 6
src/pmdas/linux/pmda.c | 30 +-
src/pmdas/linux/proc_net_dev.c | 84 +++++--
src/pmdas/linux/proc_net_dev.h | 5
src/pmdas/linux_proc/cgroups.c | 25 +-
src/pmdas/root/.gitignore | 1
src/pmdas/root/docker.c | 40 ++-
src/pmdas/root/lxc.c | 9
src/pmdas/root/root.c | 25 +-
src/pmdas/root/root.h | 13 -
src/pmgadgets/pmgadgets.info.in | 4
src/pmns/pmnsmerge.c | 36 ++-
src/pmquery/pmquery.info.in | 2
src/pmtime/pmtime.info.in | 4
src/pmview/pmview.info.in | 4
39 files changed, 1387 insertions(+), 397 deletions(-)
Details ...
commit 3e52a6d662e3543107f7b20468ed7c6c091bb9ea
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Thu May 14 16:15:46 2015 +1000
Add some additional DBG_TRACE_ATTR debug printfs for values->uptodate.
modified: src/pmdas/root/docker.c
commit 6854b9e7e92f2f301da065bedb88e193f408cfc0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed May 13 19:17:00 2015 +1000
qa/555: improve stability
After the recent pmie "start faster" changes this test has
become unstable ... tweak some of the timing constants to
try and make it more deterministic.
commit 7042bfbaf559f8125653baed36b3829e0d3145fe
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed May 13 16:42:06 2015 +1000
build: update mac plist properties, attempt an appnap workaround
Possible App Nap workaround (issue #20) as suggested by the 'net.
May or may not work on latest OSX - but its just a plist property
so no harm done even if it doesn't help.
commit b724624e8e7618703f2a8bb1d330a0bc448fcc8e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed May 13 16:39:44 2015 +1000
pmdaroot: fix race and segv with short-lived containers
commit b6a94262cb6f51b64b3083e70ba10078afab97cb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed May 13 13:09:02 2015 +1000
qa/pmdas/slow and slow_python: replace deprecated variables
Last pmdaproc.sh change dropped $python_args and $perl_args ...
use $args instead.
$python_args and $perl_args are only used in these two places in
the QA suite and nowhere else that I can find.
commit 560ce35f28643368ca3255ad12dca195f6ca4d5f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed May 13 13:07:30 2015 +1000
man/pmda.3: document the hidden variables in pmdaproc.sh
Define what the various shell variables for Install and Remove
scripts do and how to use them.
commit 6e5a30c3bf76a2b9551fbd8b96bd08b1504ec5ba
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed May 13 13:05:08 2015 +1000
pmdaproc.sh: rework
Most of the changes here are cosmetic, except ...
- retire perl_args and python_args ($args does the same job)
- fix the initializations so that most assignments are safe
before or after calling pmdaSetup
- make the implementation match the (expanded) man page
commit ec1e30e76aec2b303f88643862fcde45080ad262
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue May 12 17:33:24 2015 +1000
build: extend gitignore file set for pmdaroot
commit b08d0c375e98154708008139afadd21f722a8400
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue May 12 17:33:07 2015 +1000
qa: fix typo in an error message in test 540
commit 2adc1dc9990859c622be761e21c542fdeab77ed0
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue May 12 17:32:46 2015 +1000
pmdalinux: fix container issues, especially with networking metrics
Resolves issues listed in PR1106 - ensuring network ioctls issued
to a file descriptor opened in the correct namespace, add mnt to
the namespaces needed for network metrics using /sys (hw_addr),
fix a descriptor leak when saving the base host namespaces. Some
code refactoring to assist understanding the network refresh logic.
With Docker containers we need a buffer larger than maxhostlen in
the process ID lookup code (full 64 char docker IDs hit the limit).
Adds test 042 and 047 to exercise various aspects of the changes,
and introduces qa/common.docker to provide Docker helper code.
commit 87cda3ca355eeb37fe83bbcb080e9a9b02d18f1f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon May 11 08:44:29 2015 +1000
qa/235: new .out after recent pmnsmerge changes
commit 96ee386b3e111791540fe57dc6c480d82f7e544d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon May 11 08:43:16 2015 +1000
qa/771: oops, add missing 771.out
commit 67925543959de7e244912c0a279531ee2cdcdc9a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun May 10 17:39:48 2015 +1000
qa/772: (new) exercise duplicate options of pmnsmerge
As a by-product also tests the "duplicates are dynamic metrics"
case that was recently fixed in libpcp.
commit d152e732d082adcaea3e39412cb99e040a7834b9
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun May 10 17:35:17 2015 +1000
pmnsmerge: small duplicates in PMNS changes
1. re-instate -d (--dupok, duplicates are OK) (this is the default
and deprecated)
2. add -x (--nodups, duplicates are not allowed)
3. fix -f so implementation matches documentation (will really
overwrite the output file)
Note -x is applied to each input PMNS file _and_ the output PMNS file.
commit 0c651f5ef78fed921419116fc999d9a5b5821631
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun May 10 17:32:23 2015 +1000
libpcp/pmns.c: small duplicate names fix
Missed in the previous round of changes ... when duplicates are
NOT allowed, we were missing the comparison of dynamic names, so
in the PMNS
foo 123:*:*
and
bar 123:*:*
were not identified as duplicates. This commit fixes that.
commit 9f9cfed471b09491a8c08bfffea21759f55a1d60
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun May 10 07:25:51 2015 +1000
man/man1/pminfo.1: tidy up wording around -n and -N
|