pcp
[Top] [All Lists]

Re: additional metrics for elasticsearch PMDA

To: Ryan Doyle <rdoyle@xxxxxxxxxx>
Subject: Re: additional metrics for elasticsearch PMDA
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 20 Mar 2013 19:04:48 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <2275741.1934488.1363748314335.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Hi Ryan,

----- Original Message -----
> 
> Hi Nathan/others
> 
> Please see new patch - just disregard the previous one. This now
> transposes the results hash and "renames" the problematic key values
> so it can be easily accessed with es_value subroutine.
> 

Yep, I think this approach is much better.  I found I couldn't follow
the remapping code easily though, mainly because of the repeated hash
lookups.  I refactored it slightly to avoid those, and now it makes a
bit more sense to me - can you take a look?

Once I could see the forest for the trees, I noticed a redundant check
on $content being defined too, so removed that.  In dev now, so please
have a look for me and let me know if still works (no ES test setup).

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>