Re: [pcp] Hotproc fixes

[Ken McDonell <kenj@xxxxxxxxxxxxxxxx>]

On 29/04/15 05:38, Martins Innus wrote:

> ...   In the course of this,
> I need an error I can use when someone feeds pmstore a bad config.  The
> best I could find is PM_ERR_CONV which seems to be used elsewhere, is
> that correct?
PM_ERR_CONV is probably the closest error code, although this is most 
frequently encountered in bad pmExtractValue() calls.
Other alternatives might be PM_ERR_GENERIC (depending on what options 
you have for reporting the error, e.g. to the PMDA log file), else 
petition for a new error code by proposing a new macro PM_ERR_FOO and 
suitable text to be associated with it via pmErrStr().
The latter course of action is OK in cases where none of the existing 
errors provide a "reasonable" semantic match for the error in question, 
and is how the error codes have grown over time (about 25% of the 
current PM_ERR_* macros did not exist in PCP 1.0).