Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (2):
pmlogcheck: fix basename regression
qa/566: extend to check pmlogcheck bug exposed by pmmgr
qa/566 | 7 ++++++
qa/566.out | 10 ++++++++
src/pmlogcheck/pmlogcheck.c | 50
++++++++++++++++++++++++++++++++++++--------
3 files changed, 58 insertions(+), 9 deletions(-)
Details ...
commit 25042461c0763a2e1b134f53e73ca407efd44127
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 15 16:27:05 2015 +1000
qa/566: extend to check pmlogcheck bug exposed by pmmgr
commit 6b7ea0fdf895e2d6b11968bb7e156e14b523a257
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 15 15:04:24 2015 +1000
pmlogcheck: fix basename regression
When I merged the two versions of pmlogcheck I broke the logic
for determining the basename of the PCP archive from the command
line argument.
The problem was exposed by pmmgr which uses pmlogcheck to
validate archives with names like archive-20150415.044829.0
but uses the basename archive-20150415.044829 as a command
line argument to pmlogcheck. The old code (correctly)
interpreted this as meaning all files matching the pattern
archive-20150415.044829.{index,meta,digit...}, the new code
(incorrectly) thought this was volume 044829 of the archive with
basename archive-20150415 and then failed to find any files
matching the pattern archive-20150415.{index,meta,digit...}
... doh!
This was causing qa/666 to fail, and is fixed in this commit.
|