Hi,
Due to the feedback gained from the PCP mailing list with regards to the
dm-thin PMDA, I have undertaken thetask of merging both dm-cache and
dm-thin PMDA's into pmdadm (device-mapper)for review/inclusion.
This PMDA consolidates the functionalities of both the PMDA's whilst reusing
the PMID originally given to the dm-cache PMDA. As before both of these
PMDA's requirethe dmestup tool's status switch for their respect targets in
order tocollect data for their metrics.
Changes committed to git://github.com/pauljevans/pcp.git master
qa/657 | 23 +-
qa/657.out | 184 +++++++++--
qa/985 | 110 -------
qa/985.out | 165 ----------
qa/986 | 76 -----
qa/986.out | 28 --
qa/group | 7 +-
src/pmdas/GNUmakefile | 4 +-
src/pmdas/dm/.gitignore | 3 +
src/pmdas/dm/GNUmakefile | 61 ++++
src/pmdas/dm/Install | 34 ++
src/pmdas/dm/README | 62 ++++
src/pmdas/dm/Remove | 24 ++
src/pmdas/dm/dmcache.c | 162 ++++++++++
src/pmdas/dm/dmcache.h | 60 ++++
src/pmdas/dm/dmthin.c | 204 ++++++++++++
src/pmdas/dm/dmthin.h | 65 ++++
src/pmdas/dm/help | 119 +++++++
src/pmdas/dm/pmda.c | 591
+++++++++++++++++++++++++++++++++++
src/pmdas/dm/pmdadm.1 | 69 ++++
src/pmdas/dm/pmdadm.h | 55 ++++
src/pmdas/dm/pmns | 60 ++++
src/pmdas/dm/root | 9 +
src/pmdas/dmcache/.gitignore | 5 -
src/pmdas/dmcache/GNUmakefile | 40 ---
src/pmdas/dmcache/Install | 35 ---
src/pmdas/dmcache/Remove | 25 --
src/pmdas/dmcache/pmdadmcache.1 | 64 ----
src/pmdas/dmcache/pmdadmcache.python | 276 ----------------
src/pmdas/dmthin/.gitignore | 3 -
src/pmdas/dmthin/GNUmakefile | 60 ----
src/pmdas/dmthin/Install | 34 --
src/pmdas/dmthin/README | 64 ----
src/pmdas/dmthin/Remove | 24 --
src/pmdas/dmthin/help | 64 ----
src/pmdas/dmthin/pmda.c | 441 --------------------------
src/pmdas/dmthin/pmdadmthin.1 | 70 -----
src/pmdas/dmthin/pmdadmthin.h | 47 ---
src/pmdas/dmthin/pmns | 34 --
src/pmdas/dmthin/root | 9 -
src/pmdas/dmthin/stats.c | 201 ------------
src/pmdas/dmthin/stats.h | 59 ----
src/pmns/stdpmid.pcp | 3 +-
43 files changed, 1758 insertions(+), 1975 deletions(-)
commit 16924ebaa7d7516246ca7f12b5744efcb822462d
Author: Paul Evans <pevans@xxxxxxxxxx>
Date: Fri Mar 27 17:45:57 2015 +0000
pmdadm: Device Mapper (md) PMDA Initial Merge
Initial Device Mapper PMDA code which is a rewrite and merging of the
dm-thin and dm-cache PMDA in order to minimise PMDA proliferation.
Making use of stats given by dmsetup status for the cache, thin-pool
and thin targets we export the statistics for DM Cache, thin-pools
and thin provisioned volumes.
Providing metrics from the information given in their respected docs
cache.txt and thin-proivisioning.txt in the kernel docs/device-mapper
directory. There have been additional metrics added for the thin-pool
and thin-vol stats to give back the size of the pools/volumes. Have
also made changes as suggested by Nathan Scott to reduce the amount
of branching code in the fetch/instance functions.
QA is given by qa/657 which tests the PMDA without the need for local
thin-pools, volumes of caches. (Although the dmsetup tool is required
for the PMDA to install).
Have removed/renamed the non needed dm-thin and dm-cache PMDA's along
with their corresponding qa/tests and have used the PMID from dm-cache
as the PMID for the pmdadm.
Code checked with Coverity and has no reported issues.
The patch has been tested and has had conscan run on it. As always
please let
me know if there are any issues and as always feedback is welcome :).
Cheers,
Paul
|