Re: [pcp] pmrep: add xlsx support

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Marko,

----- Original Message -----
> [...]
> output to match PCP not sar2xls convention). A warning is printed but
> the generated archive looks to be just fine:
> 
> Use of uninitialized value in subroutine entry at sheet2pcp line 571.

Hmm, that line seems to be the closing brace of a for loop, so not
clear which variable that warning is referring to.  :(

> Since the actively developed Python XLSX modules might occasionally
> change their output (e.g. a white-space or a bug fix change) then a
> diff(1) based comparison might cause false alarms too often, this
> sheet2pcp(1) test would actually sound like a good idea, we'd be testing
> sheet2pcp(1) more as well in the process.

Yep - win, win.

cheers.

--
Nathan