On 13/03/15 02:11, Dave Brolley wrote:
...
Sorry, if this was premature. I had read Ken's responses to Frank's
performance data as positive and I also read that Ken had pulled these
changes and reviewed them favourably.
Bit of a miscommunication here I think ... Frank did provide performance
data for his pmwebd test cases (which looked encouraging early on in the
work), we don't have any performance analysis for the pmcd-side cases at
this stage AFAIK.
On the review side, I've only been pulling and reviewing the changes
that are bugs Frank's found on the other code as a result of the pdubuf
changes, so these are independent of the pdubuf implementation.
I have not reviewed the main pdubuf changes at all ... I was waiting for
a "done" flag from Frank.
Frank ... what's the status of the code Dave's pulled into the main tree
(in terms of being complete from your perspective)?
Maybe a case for a post-commit review here.
|